Last modified: 2014-02-19 17:10:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54815, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52815 - Remove "Enable simplified search bar (Vector skin only)" user preference from MediaWiki core


Summary:	Remove "Enable simplified search bar (Vector skin only)" user preference from...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	User preferences (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	1.23.0 release
Assigned To:	Tony Thomas

URL:
Whiteboard:
Keywords:	easy

Depends on:
Blocks:	52807
	Show dependency tree / graph

Reported:	2013-08-13 18:52 UTC by MZMcBride
Modified:	2014-02-19 17:10 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2013-08-13 18:52:25 UTC

The "Enable simplified search bar (Vector skin only)" user preference should be removed from MediaWiki core.

While it seems like this user preference would be inside [[mw:Extension:Vector]], it's not. It's inside includes/Preferences.php:

---
if ( $wgVectorUseSimpleSearch ) {
	$defaultPreferences['vector-simplesearch'] = array(
		'type' => 'toggle',
		'label-message' => 'vector-simplesearch-preference',
		'section' => 'searchoptions/displaysearchoptions',
	);
}
---

This should be an easy bug to resolve; marking it with the Bugzilla keyword
accordingly.

Comment 1 Tony Thomas 2013-12-04 17:34:40 UTC

I would like to prepare a patch for this bug. Please assign it to me.

Comment 2 Gerrit Notification Bot 2013-12-05 17:00:31 UTC

Change 99422 had a related patch set uploaded by 01tonythomas:
Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference

https://gerrit.wikimedia.org/r/99422

Comment 3 Derk-Jan Hartman 2013-12-20 21:01:51 UTC

We should probably not do this, until "search" action is the default when people do not have JS enabled.

Comment 4 Bartosz Dziewoński 2013-12-20 21:03:19 UTC

My https://gerrit.wikimedia.org/r/#/c/82100/ does that.

Comment 5 Gerrit Notification Bot 2014-02-19 16:59:18 UTC

Change 99422 merged by jenkins-bot:
Removed 'Enable simplified search bar (Vector skin only)' from MW user Preference

https://gerrit.wikimedia.org/r/99422

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links