Last modified: 2013-09-06 15:02:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54699, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 52699 - API upload warning exists-normalized returns wrong file (the file that is uploaded, not the file that exists)


Summary:	API upload warning exists-normalized returns wrong file (the file that is upl...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	API (Other open bugs)
Version:	1.22.0
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2013-08-10 08:55 UTC by Rainer Rillke @commons.wikimedia
Modified:	2013-09-06 15:02 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rainer Rillke @commons.wikimedia 2013-08-10 08:55:51 UTC

Original bug title:
API upload warning exists-normalized returns wrong file (the file that is uploaded, not the file that exists)

----
See https://commons.wikimedia.org/w/index.php?title=Commons:Upload_help&oldid=101150677#Cannot_find_existing_file.3F and http://bug-attachment.wikimedia.org/attachment.cgi?id=13083 where I tried to upload a PNG (and there was not PNG uploaded yet but a JPEG)

Comment 1 Rainer Rillke @commons.wikimedia 2013-08-10 09:31:18 UTC

I guess someone has to fiddle with
https://github.com/wikimedia/mediawiki-core/blob/5e5579d04cfac26317ff13cd85ed8453a113c10f/includes/api/ApiUpload.php#L567

which receives its result from
https://github.com/wikimedia/mediawiki-core/blob/5e5579d04cfac26317ff13cd85ed8453a113c10f/includes/upload/UploadBase.php#L1477

Comment 2 Rainer Rillke @commons.wikimedia 2013-08-10 11:19:32 UTC

To clarify, I think its more useful to return the "normalizedFile"-title rather than just the "file"-title. Otherwise the user has no way to find out which the normalized filename is, that exists.

Comment 3 Gerrit Notification Bot 2013-08-10 12:23:40 UTC

Change 78523 had a related patch set uploaded by Rillke:
Return normalized file name on warning "exists-normalized"

https://gerrit.wikimedia.org/r/78523

Comment 4 Gerrit Notification Bot 2013-09-06 14:59:19 UTC

Change 78523 merged by jenkins-bot:
Return normalized file name on warning "exists-normalized"

https://gerrit.wikimedia.org/r/78523

Comment 5 Brad Jorsch 2013-09-06 15:02:22 UTC

This change should be deployed to WMF wikis with 1.22wmf17, see https://www.mediawiki.org/wiki/MediaWiki_1.22/Roadmap for the schedule.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links