Last modified: 2014-05-31 12:39:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54343, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 52343 - Invalidate navbar cache when JSON is edited
Invalidate navbar cache when JSON is edited
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
BookManagerv2 (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Deepali Jain
http://www.google-melange.com/gci/tas...
:
Depends on:
Blocks: 50386
  Show dependency treegraph
 
Reported: 2013-07-31 20:08 UTC by Molly White
Modified: 2014-05-31 12:39 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Molly White 2013-07-31 20:08:32 UTC
As mwalker said: "if you are creating the navigation bar in php; that means it gets cached for logged out users; which means that you would have to invalidate all constituent pages in a book every time the json changes"

A note for later: he suggests this can be done using

Title::makeTitle(1, 'foo')->purgeSquid()
Comment 1 Quim Gil 2013-12-04 18:02:48 UTC
Published as Google Code-in task.
Comment 2 Subin Siby 2013-12-28 14:10:22 UTC
Will just executing the function :

Title::makeTitle(1, 'foo')->purgeSquid()

invalidate all constituent pages in a book ?
So, I should add this code in the proper place, Right ?
Comment 3 Gerrit Notification Bot 2013-12-28 16:44:26 UTC
Change 104208 had a related patch set uploaded by Geek400:
Bug 52343

https://gerrit.wikimedia.org/r/104208
Comment 4 Gerrit Notification Bot 2013-12-29 12:11:13 UTC
Change 104335 had a related patch set uploaded by Geek400:
BookManagerv2: Clear cache when JSON file changes

https://gerrit.wikimedia.org/r/104335
Comment 5 Gerrit Notification Bot 2014-01-04 13:56:03 UTC
Change 105441 had a related patch set uploaded by Mayankmadan:
BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes.

https://gerrit.wikimedia.org/r/105441
Comment 6 Mayank Madan 2014-01-04 17:39:17 UTC
How about just using Title::newFromText() method to get a title object and then run purgeSquid() on it?
Comment 7 Mayank Madan 2014-01-04 20:57:47 UTC
How about https://github.com/wikimedia/mediawiki-core/blob/master/includes/job/jobs/HTMLCacheUpdateJob.php#L137-154 for a solution?
Something like this to purge all the pages?
Comment 8 Gerrit Notification Bot 2014-02-01 15:22:34 UTC
Change 104335 abandoned by Siebrand:
BookManagerv2: Clear cache when JSON file changes

Reason:
This is simply a newline.

https://gerrit.wikimedia.org/r/104335
Comment 9 Gerrit Notification Bot 2014-03-01 16:53:52 UTC
Change 105441 abandoned by Bartosz Dziewoński:
BookManagerv2: Invalidate navbar cache when JSON file changes Invalidate all constituent pages in a book when the JSON file changes.

Reason:
There's no will from the uploader to improve this, clearing up the backlog.

https://gerrit.wikimedia.org/r/105441

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links