Last modified: 2013-08-22 14:14:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54321, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52321 - the message diff-multi above comparison of several revisions has wrong directionality
the message diff-multi above comparison of several revisions has wrong direct...
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Amir E. Aharoni
: i18n, need-volunteer
Depends on:
Blocks: rtl-wikidata
  Show dependency tree / graph
 
Reported: 2013-07-31 12:07 UTC by Amir E. Aharoni
Modified: 2013-08-22 14:14 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2013-07-31 12:07:00 UTC 
To reproduce:

1. Go to https://www.wikidata.org/w/index.php?title=Q12060906&diff=56007681&oldid=53789438&uselang=he

2. Inspect the message above the diff - (7 גרסאות ביניים של 6 משתמשים אינן מוצגות).

Observed: The CSS property direction is "ltr".

Expected: The CSS property direction must be "rtl", because it's Hebrew.

I suspect that it happens because the function that adds this message uses getPageLanguage, while it should use the user language, but I didn't test too deeply.
Comment 1 Gerrit Notification Bot 2013-08-16 11:14:05 UTC 
Change 79326 had a related patch set uploaded by Amire80:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326
Comment 2 Gerrit Notification Bot 2013-08-20 08:51:53 UTC 
Change 79326 merged by jenkins-bot:
Add diff-multi to classes with explicit direction

https://gerrit.wikimedia.org/r/79326
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links