Last modified: 2014-07-04 09:22:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T54214, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 52214 - Wikidata logo incorrect
Wikidata logo incorrect
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
WikimediaIncubator (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 67519 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-29 11:37 UTC by zhuyifei1999
Modified: 2014-07-04 09:22 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to add exception (1.06 KB, patch)
2013-07-29 17:21 UTC, Étienne Beaulé 		Details
Add an attachment (proposed patch, testcase, etc.)

Description zhuyifei1999 2013-07-29 11:37:29 UTC 
For example [[:i:Wp/zh]] has an English Wikipedia logo instead of Wikidata's.
Comment 1 zhuyifei1999 2013-07-29 11:38:51 UTC 
[[:incubator:Wp/zh]]
Comment 2 Étienne Beaulé 2013-07-29 11:41:39 UTC 
Confirmed.
Comment 3 zhuyifei1999 2013-07-29 11:49:52 UTC 
It still displays UNCONFIRMED
Comment 4 Étienne Beaulé 2013-07-29 17:21:30 UTC 
Created attachment 13006 [details]
Patch to add exception

Added a "if" for $site Wikidata to give "//upload.wikimedia.org/wikipedia/commons/e/e4/Wikidata-logo-en-135px.png" as an image
Comment 5 Robin Pepermans (SPQRobin) 2013-07-30 09:10:00 UTC 
The proposed patch is a hack and not an ideal fix.

The actual problem is that in InitialiseSettings.php Wikidata uses both 'wikidata' and 'wikidatawiki' as keys, whereas the Incubator extension depends on 'wikidatawiki' as key (like 'commonswiki' etc). It takes the key from $wmincMultilingualProjects and adds 'wiki' to it.
Comment 6 Étienne Beaulé 2013-07-31 00:54:02 UTC 
I saw that studying the code yesterday.
Comment 7 Robin Pepermans (SPQRobin) 2014-07-04 09:21:54 UTC 
*** Bug 67519 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links