Last modified: 2014-07-17 19:36:37 UTC
gerritadmin is doing more and more stuff (now also setting PATCH_TO_REVIEW status), it has to be documented. One line of description on wikitech wiki, a link to its code and to the server where it lives, possibly a mention of a maintainer, should be enough. (Currently I don't even know who to ask this.)
It's not a bot, it's a plugin called hooks-bugzilla and the code is upstream.
Well, its current bugzilla username/"real name" is Gerrit Notification Bot. If the code is upstream, add to comment 0 "a link to its configuration" or whatever.
Config is in puppet along with all the other gerrit config?
(In reply to comment #1) > It's not a bot, it's a plugin called hooks-bugzilla and the code is upstream. https://gerrit.googlesource.com/plugins/hooks-bugzilla (In reply to comment #3) > Config is in puppet along with all the other gerrit config? https://git.wikimedia.org/blob/operations%2Fpuppet.git//templates%2Fgerrit%2Fgerrit.config.erb (Something unrelated I noticed there is that if you click the HEAD link, you get 'Internal error'. https://git.wikimedia.org/log/operations%2Fpuppet.git gives "Failed to find commit "HEAD" in operations/puppet.git!" and I'm guessing it's to do with 'production' being the default branch in that repository instead of 'master'.)
(In reply to comment #4) > (Something unrelated I noticed there is that if you click the HEAD link, you > get 'Internal error'. https://git.wikimedia.org/log/operations%2Fpuppet.git > gives "Failed to find commit "HEAD" in operations/puppet.git!" and I'm > guessing > it's to do with 'production' being the default branch in that repository > instead of 'master'.) Looks like this was reported as bug 50152, please ignore.
(In reply to comment #5) > (In reply to comment #4) > > (Something unrelated I noticed there is that if you click the HEAD link, you > > get 'Internal error'. https://git.wikimedia.org/log/operations%2Fpuppet.git > > gives "Failed to find commit "HEAD" in operations/puppet.git!" and I'm > > guessing > > it's to do with 'production' being the default branch in that repository > > instead of 'master'.) > > Looks like this was reported as bug 50152, please ignore. Which I've also reported to the upstream dev as well ;-)
Thanks for reporting this bug, Nemo. I started a page here: <https://wikitech.wikimedia.org/wiki/Gerrit_Notification_Bot>. I created the following redirects: * https://wikitech.wikimedia.org/wiki/Gerrit_notification_bot * https://wikitech.wikimedia.org/wiki/gerritadmin * https://wikitech.wikimedia.org/wiki/hooks-bugzilla I added pointers to the following pages: * https://wikitech.wikimedia.org/wiki/Gerrit#See_also * https://wikitech.wikimedia.org/wiki/bugzilla.wikimedia.org#See_also * https://wikitech.wikimedia.org/wiki/grrrit-wm#See_also
(In reply to comment #7) > Thanks for reporting this bug, Nemo. > > I started a page here: > <https://wikitech.wikimedia.org/wiki/Gerrit_Notification_Bot>. Thank you. I see there are a couple open questions, then this bug can be closed. :)
(In reply to Nemo from comment #8) > Thank you. I see there are a couple open questions, but no longer, > then this bug can be > closed. :)
