Last modified: 2013-10-09 14:17:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53876, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51876 - populateSitesTable populates interwiki codes incorrectly for non-wikipedias
populateSitesTable populates interwiki codes incorrectly for non-wikipedias
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: Highest critical (vote)
: ---
Assigned To: Wikidata bugs
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-23 12:45 UTC by Aude
Modified: 2013-10-09 14:17 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2013-07-23 12:45:56 UTC 
the insert sites code has wikipedia specific code and populates the site_identifiers table correctly only for wikipedia sites.
Comment 1 Aude 2013-07-23 13:21:47 UTC 
For example, the site identifiers table should have an interwiki code of 'en' for enwikivoyage.

so, si_type = 'interwiki' and si_key = 'en'

The site_identifiers table has a unique key set for si_type and si_key, so it is unable to add the correct interwiki codes for non-wikipedias.

Unless there is a good reason for this unique key, it should be removed so this table can be populated correctly.

CREATE TABLE `site_identifiers` (
  `si_site` int(10) unsigned NOT NULL,
  `si_type` varbinary(32) NOT NULL,
  `si_key` varbinary(32) NOT NULL,
  UNIQUE KEY `site_ids_type` (`si_type`,`si_key`),
  KEY `site_ids_site` (`si_site`),
  KEY `site_ids_key` (`si_key`)
)
Comment 2 Aude 2013-07-23 13:45:16 UTC 
the result of this bug is that non-wikipedia interwiki links display like "frwikivoyage:Paris" and do not render correctly.
Comment 3 Gerrit Notification Bot 2013-07-23 13:59:02 UTC 
Change 75334 had a related patch set uploaded by Aude:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75334
Comment 4 Gerrit Notification Bot 2013-07-23 16:45:01 UTC 
Change 75334 merged by jenkins-bot:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75334
Comment 5 Gerrit Notification Bot 2013-07-23 17:03:08 UTC 
Change 75355 had a related patch set uploaded by Aude:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75355
Comment 6 Gerrit Notification Bot 2013-07-23 17:04:49 UTC 
Change 75358 had a related patch set uploaded by Aude:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75358
Comment 7 Gerrit Notification Bot 2013-07-23 17:10:52 UTC 
Change 75358 merged by Aude:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75358
Comment 8 Gerrit Notification Bot 2013-07-23 17:14:14 UTC 
Change 75355 merged by Aude:
(bug 51876, hotfix) ensure interwiki links render correctly in sidebar

https://gerrit.wikimedia.org/r/75355
Comment 9 Andre Klapper 2013-09-06 10:10:05 UTC 
Aude:
Now that all patches are merged: Is there anything left to do here, or can this be closed as FIXED?
Comment 10 Gerrit Notification Bot 2013-09-17 16:29:09 UTC 
Change 84520 had a related patch set (by Aude) published:
(bug 51876) handle populates sites table interwiki ids correctly

https://gerrit.wikimedia.org/r/84520
Comment 11 Gerrit Notification Bot 2013-09-18 15:07:07 UTC 
Change 84520 merged by jenkins-bot:
(bug 51876) handle populates sites table interwiki ids correctly

https://gerrit.wikimedia.org/r/84520
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links