Last modified: 2013-07-24 01:27:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53851, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51851 - VisualEditor: By default, images should not set the alignment
VisualEditor: By default, images should not set the alignment
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-07-25
Assigned To: Moriel Schottlender
: i18n
: 51295 (view as bug list)
Depends on:
Blocks: ve-rtl
  Show dependency treegraph
 
Reported: 2013-07-23 08:28 UTC by Amir E. Aharoni
Modified: 2013-07-24 01:27 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-07-23 08:28:59 UTC
The VisualEditor explicitly sets all images that are inserted using the dialog as thumb and right. "thumb" is fine, because it's not default, but that's what people want most of the time, but "right" shouldn't be there. "right" is the default for left-to-right Wikipedias, so it's redundant in English. The default for right-to-left Wikipedias is "left", so for these languages this behavior is unexpected.

The best solution is simply not to set the alignment and let the user change if it is needed.
Comment 1 Moriel Schottlender 2013-07-23 14:01:03 UTC
Should we remove the alignment completely (and risk people not putting one in? what's the potential side-effect of that?) or change the 'right' to 'left' on RTL wikis?
Comment 2 Amir E. Aharoni 2013-07-23 14:06:39 UTC
Unless I'm missing something, just remove if it's the default anyway. See an example:
https://en.wikipedia.org/wiki/User:Amire80/ve_default_image_alignment
Comment 3 Bartosz Dziewoński 2013-07-23 22:52:08 UTC
*** Bug 51295 has been marked as a duplicate of this bug. ***
Comment 4 Gerrit Notification Bot 2013-07-23 23:14:38 UTC
Change 75526 had a related patch set uploaded by Mooeypoo:
Image insertion alignment fix

https://gerrit.wikimedia.org/r/75526
Comment 5 Gerrit Notification Bot 2013-07-24 00:27:22 UTC
Change 75526 merged by jenkins-bot:
Image insertion alignment fix

https://gerrit.wikimedia.org/r/75526

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links