Last modified: 2014-10-10 21:48:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53772, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51772 - Broken table, repeated section in diff after VisualEditor edit
Broken table, repeated section in diff after VisualEditor edit
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
:
Depends on:
Blocks: ve-tablesupport
  Show dependency treegraph
 
Reported: 2013-07-21 14:18 UTC by Zell Faze
Modified: 2014-10-10 21:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Zell Faze 2013-07-21 14:18:48 UTC
I recently ran across [https://en.wikipedia.org/w/index.php?title=Polycarbonate&diff=prev&oldid=564618311 this edit].  It seems as though they were trying to fix a spelling correction and inadvertently destroyed a table and had an entire section get repeated.

There was a little [https://en.wikipedia.org/wiki/Wikipedia:VisualEditor/Feedback#Strange_Diff discussion about the diff on the Visual Editor feedback page], where it was mentioned that the diff "is very strange and [the commenter didn't] recall seeing anything similar".
Comment 1 ssastry 2013-07-22 15:20:56 UTC
The problem is that the table wikitext is buggy there.  It is missing a closing tag (in reality, it is missing a newline break.  |-|} .. See https://en.wikipedia.org/w/index.php?title=Polycarbonate&action=edit&oldid=563700122)

The PHP parser output for this is also broken (see https://en.wikipedia.org/w/index.php?title=Polycarbonate&oldid=563700122#Manufacturers_and_brands and where the table has ended up).

We could improve Parsoid to detect some scenarios like this, but it is currently lower priority.  Fixing the table by adding a line break between "|-" and "|}" should fix the issue for now.

Sample wikitext snippet for our use later:

{|
|foo
|-|}
abc
Comment 2 James Forrester 2014-10-10 21:48:59 UTC
This was fixed a very long time ago (around August last year), but I didn't spot this report until just now; my apologies.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links