Last modified: 2011-04-14 15:13:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T7176, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 5176 - Make access declarations private protected and public really mean it
Make access declarations private protected and public really mean it
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: 8000 (view as bug list)
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2006-03-06 01:19 UTC by Edward Z. Yang
Modified: 2011-04-14 15:13 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Edward Z. Yang 2006-03-06 01:19:24 UTC
I'm not sure how widespread the problem is, but certain classes misuse the
docblock's @access declaration. That is, if the access restrictions were to
translate straight to actual language level declarations in PHP5, you'd break a
lot of functionality. For now, I just know that HTMLForm.php couldn't possibly
be a class of only private methods (and nothing else). That would be quite
useless. I think they're supposed to be protected, but public would be even nicer.

A related bug would also ask for certain interfaces that were originally private
to be made public for extensions to use.

Assigned as blocker to Brion's "Our docs are teh suck" bug and added to the code
quality tracking bug.
Comment 1 Rob Church 2006-11-21 03:47:04 UTC
*** Bug 8000 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.