Last modified: 2014-06-17 23:27:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53708, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51708 - VisualEditor: Inline templates don't wrap, assume width:100%, so break layout around floated items
VisualEditor: Inline templates don't wrap, assume width:100%, so break layout...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-06-19
Assigned To: Ed Sanders
:
: 52320 62800 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-19 20:38 UTC by Chris McKenna
Modified: 2014-06-17 23:27 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McKenna 2013-07-19 20:38:12 UTC
In Visual Editor edit screen templates that produce a single line of displayed text (regardless of the length of that line) do not wrap on word boundaries.

Steps to reproduce:
1. Insert a picture or other right-aligned object that text should wrap around.
2. Transclude a template that produces a single line of text. {{EW charity|123456|This charity has got a long name to make it easy to test this bug}} is an example
3. Reduce the width of your browser window until the text produced by the template is longer than the avaialble space between the left margin and the picture.

Expected behaviour: The last word(s) of the text produced by the template wraps onto a second line.
Actual behaviour: The entire line moves to below the picture as a single unit.

Any template that produces two or more lines of displayed text (on an infinitely wide window) does not exhibit this behaviour and wraps correctly. For example:

"Long text<br>1" wraps correctly

"Long text
1"
"Long text<br>" and
"Long text<br>
<!--hidden-->" all exhibit this bug.
Comment 1 James Forrester 2014-03-07 20:25:28 UTC
*** Bug 52320 has been marked as a duplicate of this bug. ***
Comment 2 James Forrester 2014-03-18 19:06:14 UTC
*** Bug 62800 has been marked as a duplicate of this bug. ***
Comment 3 Ed Sanders 2014-06-15 13:01:29 UTC
Inline templates are overridden to inline-block, but setting them back to inline would mean we have to calculate the highlights using getClientRects. Might want to wait for the much discussed SVG highlights for this?
Comment 4 Gerrit Notification Bot 2014-06-16 10:53:53 UTC
Change 139806 had a related patch set uploaded by Esanders:
Remove display:inline-block highlight hacks

https://gerrit.wikimedia.org/r/139806
Comment 5 Gerrit Notification Bot 2014-06-17 23:27:12 UTC
Change 139806 merged by jenkins-bot:
Remove display:inline-block highlight hacks

https://gerrit.wikimedia.org/r/139806

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links