Last modified: 2014-03-06 02:45:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53672, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51672 - VisualEditor: Move the remove template/parameter button to somewhere more prominent?
VisualEditor: Move the remove template/parameter button to somewhere more pro...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-03-06
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-templatesupport
  Show dependency treegraph
 
Reported: 2013-07-19 10:18 UTC by Chris McKenna
Modified: 2014-03-06 02:45 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Lack of "remove template" button in a 1366x480px Firefox 22 window on Xubuntu Linux (33.95 KB, image/png)
2013-07-19 10:18 UTC, Chris McKenna
Details

Description Chris McKenna 2013-07-19 10:18:26 UTC
Created attachment 12893 [details]
Lack of "remove template" button in a 1366x480px Firefox 22 window on Xubuntu Linux

In the Visual Editor template/transclusion editor the list of parameters obscures the "remove template" button so that it can only be clicked if you enter the name of a non-existant parameter into the search box. See attachment to bug 51671

Even this does not help when the window is too small for it to be displayed (see attachment).

Both problems could be solved by either: 
*making the window scroll (separately from making the parameter list scroll); and/or
*moving the "Remove template" button next to the "save changes" button (which would probably be more logical than placing it under "options" - see also bug 51135).
Comment 1 Chris McKenna 2013-07-24 21:12:02 UTC
The fix to bug 51739 has made this less of an issue, in that the remove template button can be accessed by scrolling to the very bottom of the list. I still think the button would be better placed next to the "save changes" button though.

Changing from a bug to an enhancement accordingly.
Comment 2 James Forrester 2013-08-01 02:54:32 UTC
(In reply to comment #0)
> *moving the "Remove template" button next to the "save changes" button (which
> would probably be more logical than placing it under "options" - see also bug
> 51135).

The problem is that button removes the single template that the pane is about, not the entire transclusion (which can cover from one template to thousands) - the dialog footer buttons are meant to apply to the entire dialog's subject, not just the bit you're currently looking at.

However, maybe it could be up in the top-right, alongside the name of the template you've currently got selected?
Comment 3 Chris McKenna 2013-08-01 06:46:16 UTC
(In reply to comment #2)
> The problem is that button removes the single template that the pane is
> about,
> not the entire transclusion (which can cover from one template to thousands)
> -
> the dialog footer buttons are meant to apply to the entire dialog's subject,
> not just the bit you're currently looking at.

Ah rights, yes that does make sense

> However, maybe it could be up in the top-right, alongside the name of the
> template you've currently got selected?

Right aligned on the same line as the template name / parameter name (for remove parameter) does seem like the best. Need to make sure that it doesn't collide with a long template/parameter name though.
Comment 4 James Forrester 2014-03-06 02:45:36 UTC
The button has now been moved to the right of the template or parameter's name.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links