Last modified: 2014-01-12 15:30:19 UTC
wgUserNewMsgRevisionId is apparently null when user talk page has only one revision, even if the user hasn't viewed it yet. May be caused by Notifications interfering with something (I only tested on test.wp); certainly matters for it, though, as this causes the orange alert not to appear for new users ([[File:Echo Notifications new message indicator.png|this one]]). Therefore marking as 'major'.
Confirmed in master branch.
[23:39] <kaldari> looks like $user->getNewMessageRevisionId() is returning null even after the first post for some reason.
Change 74547 had a related patch set uploaded by Kaldari: Making sure wgUserNewMsgRevisionId works even for the first post https://gerrit.wikimedia.org/r/74547
Change 74547 abandoned by Kaldari: Making sure wgUserNewMsgRevisionId works even for the first post Reason: wrong approach https://gerrit.wikimedia.org/r/74547
Change 74666 had a related patch set uploaded by Bsitu: (bug 51640) wgUserNewMsgRevisionId is null with only one rev https://gerrit.wikimedia.org/r/74666
Change 74666 merged by jenkins-bot: (bug 51640) wgUserNewMsgRevisionId is null with only one rev https://gerrit.wikimedia.org/r/74666
Change 76824 had a related patch set uploaded by Bsitu: Revert "(bug 51640) wgUserNewMsgRevisionId is null with only one rev" https://gerrit.wikimedia.org/r/76824
Change 76824 merged by jenkins-bot: Revert "(bug 51640) wgUserNewMsgRevisionId is null with only one rev" https://gerrit.wikimedia.org/r/76824
All patches got merged - can this bug report be closed as RESOLVED FIXED or is more work required?
The patch was merged, but then reverted.
Echo's alert bar now doesn't require JavaScript, let's try doing this once again.
