Last modified: 2014-06-17 17:02:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53564, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51564 - Vector: Module "ext.vector.footerCleanup" and "ext.vector.collapsibleNav" should not each load in a separate http request
Vector: Module "ext.vector.footerCleanup" and "ext.vector.collapsibleNav" sho...
Status: RESOLVED FIXED
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Normal major
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-17 18:50 UTC by Krinkle
Modified: 2014-06-17 17:02 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-07-17 18:50:31 UTC
In production right now we're causing RL to have to do a separate HTTP request for modules like "ext.vector.footerCleanup".

This is pointless, it should be part of the regular queue that is on every page. It was perhaps useful in the past when there were more modules in the "ext.vector" group that load on every page from the same queue (so that different pages with different modules in their queue would share this cache), but right now this is the only one left and no longer justified being in a separate request.
Comment 1 Krinkle 2013-07-17 18:53:15 UTC
Since ext.vector.footerCleanup and ext.vector.collapsibleNav are in the top and bottom queue respectively they also don't load together but are two separate requests.
Comment 2 Bartosz Dziewoński 2013-07-17 20:23:57 UTC
Well, the best way to fix this would be to just fix bug 45051.
Comment 3 MZMcBride 2013-07-18 01:38:16 UTC
(In reply to comment #2)
> Well, the best way to fix this would be to just fix bug 45051.

Agreed.
Comment 4 Gerrit Notification Bot 2013-07-18 01:49:27 UTC
Change 74315 had a related patch set uploaded by Krinkle:
Remove cache group "ext.vector" from modules definitions

https://gerrit.wikimedia.org/r/74315
Comment 5 Krinkle 2013-07-18 01:55:52 UTC
True, but that might take a while.

Saving 2 http requests globally is a big fish to catch for such a small bait.
Comment 6 Gerrit Notification Bot 2013-07-19 00:21:15 UTC
Change 74315 merged by jenkins-bot:
Remove cache group "ext.vector" from modules definitions

https://gerrit.wikimedia.org/r/74315

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links