Last modified: 2014-05-15 11:51:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53404, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51404 - VisualEditor: Link inspector crashes when inserting link on non-linkable or empty selection
VisualEditor: Link inspector crashes when inserting link on non-linkable or e...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High critical
: VE-deploy-2013-08-15
Assigned To: Rob Moen
:
: 51984 (view as bug list)
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-07-15 22:33 UTC by Krinkle
Modified: 2014-05-15 11:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of problem (22.26 KB, image/png)
2013-07-15 22:34 UTC, Krinkle
Details

Description Krinkle 2013-07-15 22:33:14 UTC
* Edit a page
* Put cursor at the end of a line
* Go to toolbar and Insert new link
* The input field is focussed, blur it by clicking somewhere inside the inspector outside the input field
* Click the trash can (since there is no "x" close button, that's the closest I can find in the top left or right corner)
* The inspector clears itself but stays behind (crashes half-way closing)


Uncaught Error: No class registered by that name: undefined ve.Factory.js:62
ve.Factory.create ve.Factory.js:62
ve.dm.SurfaceFragment.annotateContent ve.dm.SurfaceFragment.js:518
ve.ui.AnnotationInspector.onClose ve.ui.AnnotationInspector.js:162
ve.ui.Window.close ve.ui.Window.js:281
ve.ui.Inspector.onRemoveButtonClick ve.ui.Inspector.js:89
oo.EventEmitter.emit oo.js:421
ve.ui.IconButtonWidget.onClick ve.ui.IconButtonWidget.js:61
proxy load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130715T175253Z:775
jQuery.event.dispatch load.php?debug=true&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20130715T175253Z:3058
elemData.handle.eventHandle


An empty inspector stays behind and the user can no longer interact with any links at this point. When doing anything (scrolling, typing) the inspector will hide. Except the bubble tip on top, that one stays behind...
Comment 1 Krinkle 2013-07-15 22:33:50 UTC
Note, this doesn't seem a race condition or anything. I'm giving it at least half a second to a second of time between each distinct action.
Comment 2 Krinkle 2013-07-15 22:34:13 UTC
Created attachment 12854 [details]
Screenshot of problem
Comment 3 Krinkle 2013-07-18 12:00:46 UTC
It could be just be, but I run into this quite often. Every time it happens the interface crashes unrecoverably and all work is lost.
Comment 4 Chris McKenna 2013-07-20 17:54:55 UTC
I've just tested this and can reproduce it except for comment 3 - in my test I was able to do everything except link and the save worked as expected.
Comment 5 John Mark Vandenberg 2013-07-21 22:07:56 UTC
Bug 51415 is reporting the same JS error in the same component, with different steps to reproduce.
Comment 6 John Mark Vandenberg 2013-07-28 08:04:38 UTC
I can reproduce this by putting the cursor on a blank line (such as an empty page), clicking link inspector icon, then pressing key 'Esc'.
Comment 7 Gerrit Notification Bot 2013-07-30 22:06:50 UTC
Change 76839 had a related patch set uploaded by Trevor Parscal:
The greatest commit in the history of the world*

https://gerrit.wikimedia.org/r/76839
Comment 8 Gerrit Notification Bot 2013-07-31 20:54:51 UTC
Change 76839 merged by jenkins-bot:
Link inspector bug fixes

https://gerrit.wikimedia.org/r/76839
Comment 9 James Forrester 2013-07-31 21:08:45 UTC
This is now merged and will be deployed later.
Comment 10 Krinkle 2013-10-30 22:46:27 UTC
*** Bug 51984 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links