Last modified: 2014-08-27 19:19:54 UTC
Per https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications#Thanked_twice It's possible to thank a user for the same edit, twice. Example: I have the history page, and a specific diff-change, open in separate tabs/windows. If I "thank" in one of those tabs, and don't refresh the other tab, then the second "thank" link doesn't auto-update to "thanked". Given how rare this situation is likely to be, and how complicated a fix is likely to be (?), I imagine this won't be fixed/fixable. Reporting for record-keeping.
Yikes. See the thread linked in first comment (permalink: https://en.wikipedia.org/w/index.php?title=Wikipedia_talk:Notifications&oldid=564293462#Thanked_twice ) for an update. One user has discovered how to accidentally "thank" a multitude of times, for the same edit, via "control-clicking" on any link in the "revision history" page, after a thank has been sent/confirmed.
After a quick review on the code, the fix should be pretty straight forward. The state of 'Thanks' is saved into user's web session. Before sending a thanks notification, just skip sending 'Thanks' notification if a previous 'Thanks' has been sent for the revision
Change 73732 had a related patch set uploaded by Bsitu: (bug 51303) Do not send duplicate thanks notification https://gerrit.wikimedia.org/r/73732
Change 73732 merged by jenkins-bot: (bug 51303) Do not send duplicate thanks notification https://gerrit.wikimedia.org/r/73732
(In reply to comment #4) > Change 73732 merged by jenkins-bot: > (bug 51303) Do not send duplicate thanks notification > > https://gerrit.wikimedia.org/r/73732 I'm marking this bug resolved/fixed accordingly. Please feel free to re-open this bug if you continue to see this issue (duplicate thanks) in a few days after this change is deployed.
Re-opening, per fresh report of a doublethank (with a many hour time-gap between them) from Redrose64 at https://en.wikipedia.org/wiki/Wikipedia_talk:Notifications/Thanks#Doublethank
*** Bug 57584 has been marked as a duplicate of this bug. ***
The problem is that we store Thanks in session data, which shouldn't be and isn't a persistent cache. We can either create our own database table for storage, or maybe use wfGetCache( CACHE_DB )? Not sure what our options for persistent storage on the WMF cluster are.
See also: https://www.wikidata.org/w/index.php?title=Special:Log&type=thanks&user=Ricordisamoa&page=User:Lydia_Pintscher_%28WMDE%29&year=2014&month=1&limit=5
(In reply to comment #8) > The problem is that we store Thanks in session data, which shouldn't be and > isn't a persistent cache. > > We can either create our own database table for storage, or maybe use > wfGetCache( CACHE_DB )? Not sure what our options for persistent storage on > the > WMF cluster are. Making thanks log public (Bug 49087) would solve the issue.
Still happening. These two thanks https://en.wikipedia.org/w/index.php?title=Special%3ALog&type=thanks&user=Malikhpur&page=User%3ARedrose64 were both for the same edit https://en.wikipedia.org/w/index.php?title=Category:Punjabi_folk_religion&oldid=prev&diff=594057858
*** Bug 61883 has been marked as a duplicate of this bug. ***
Still happens to me regularly (le sigh). The history for a given page forgets I already thanked a bunch of people. Apparently the Thanks are correctly mentioned in the relevant Log though, so there's this workaround.
*** Bug 70100 has been marked as a duplicate of this bug. ***
