Wikimedia Bugzilla is closed!

The choice of data source for $wgServerName in DefaultSettings.php leads to
problems on some types of virtual hosts.  For example, I run a wiki hosted
www.nearlyfreespeech.net (unfortunately it is private, so I can't demonstrate a
test).  BTW - NFS are fantastic hosts.  Shameless plug, no I don't get anything
out of it, however I would like to support them and people hosted by them as
much as possible, hence solving this bug before reporting it!

My www.example.com/wiki/index.php page nicely generates my files, until such
time as I edit a page - then it redirects to
mywebsitename.cust.nearlyfreespeech.net/wiki/index.php and my user credentials
are all lost (both from .htaccess and from the wiki user login).  My pages also
now look like they're from mywebsitename.cust.nearlyfreespeech.net in the
address bar, which means people might bookmark something other the cannonical site.

A very simple solution is to re-order the choice of where the $wgServer is
generated to use HTTP_HOST first in DefaultSettings.php (what I am now using -
problem solved).

However I assume there is a _reason_ for this specific search order for the
$wgServer.

While fixing that, it might also be appropriate to look at the "generated by"
$hostname from function reportTime() in OutputPage.php - however in the code
there a reason is discussed for using $_SERVER['SERVER_NAME'] rather than
$_SERVER['HTTP_HOST']

If there are good reason for using one data source rather than another, please
add this as a comment in the code so that people like me can find it there when
we hack - and possibly an indication of what might get broken if we do change it
(i.e. what might be wrong with using $_SERVER['HTTP_HOST']?)

Cheers
Shamus Husheer


From "DefaultSettings.php"

/** URL of the server. It will be automaticly build including https mode */
$wgServer = '';

if( isset( $_SERVER['SERVER_NAME'] ) ) {
	$wgServerName = $_SERVER['SERVER_NAME'];
} elseif( isset( $_SERVER['HOSTNAME'] ) ) {
	$wgServerName = $_SERVER['HOSTNAME'];
} elseif( isset( $_SERVER['HTTP_HOST'] ) ) {
	$wgServerName = $_SERVER['HTTP_HOST'];
} elseif( isset( $_SERVER['SERVER_ADDR'] ) ) {
	$wgServerName = $_SERVER['SERVER_ADDR'];
} else {
	$wgServerName = 'localhost';
}


My changed search order, which fixes the problem (at least for me):


if( isset( $_SERVER['HTTP_HOST'] ) ) {
	$wgServerName = $_SERVER['HTTP_HOST'];
} elseif( isset( $_SERVER['HOSTNAME'] ) ) {
	$wgServerName = $_SERVER['HOSTNAME'];
} elseif( isset( $_SERVER['SERVER_NAME'] ) ) {
	$wgServerName = $_SERVER['SERVER_NAME'];
} elseif( isset( $_SERVER['SERVER_ADDR'] ) ) {
	$wgServerName = $_SERVER['SERVER_ADDR'];
} else {
	$wgServerName = 'localhost';
}