Last modified: 2013-10-08 08:44:26 UTC
For a extreme example, consider this filter: https://en.wikipedia.org/wiki/Special:AbuseFilter/473 How can it consumes 23296 conditions if the condition limit is set to 1000? Why does that value changes every second? (reloading the page a few times I got: 51172, then 3986, then 7859, 14690, and so on...) This is very confusing for users trying to debug and optimize the existing filters...
I don't know if this is a problem, but I noticed the function getFilterProfile uses three keys: wfMemcKey( 'abusefilter', 'profile', $filter, 'count' ); wfMemcKey( 'abusefilter', 'profile', $filter, 'total' ); wfMemcKey( 'abusefilter', 'profile-conds', 'total' ); But the resetFilterProfile only resets the first two. Shouldn't it also reset the key profile-conds? [1] https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FAbuseFilter.git/HEAD/AbuseFilter.class.php#L535
See also: https://en.wikipedia.org/wiki/Wikipedia_talk:Edit_filter?oldid=564103784#Request_for_Interpretation
(In reply to comment #0) > For a extreme example, consider this filter: > https://en.wikipedia.org/wiki/Special:AbuseFilter/473 > > How can it consumes 23296 conditions if the condition limit is set to 1000? Where exactly can I see that (position in the UI)?
There is a line like this: --------------------------------------------------------------------------- Statistics: Of the last 147 actions, this filter has matched 4 (2.72%). On average, its run time is 1.77 ms, and it consumes 13,105 conditions of the condition limit. --------------------------------------------------------------------------- (the text comes from [[MediaWiki:abusefilter-edit-status]])
It really doesn't known what a "limit" is: I just saw it saying filter 473 consumes 112,686 conditions (!)
See also: https://www.mediawiki.org/wiki/Extension:AbuseFilter/Rules_format#Conditions (added and documented by Helder)
