Last modified: 2013-11-19 09:55:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53162, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 51162 - gerrit-wm no longer relays "Change abandoned" and 2+ inline comments events
gerrit-wm no longer relays "Change abandoned" and 2+ inline comments events
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-07-11 09:48 UTC by Nemo
Modified: 2013-11-19 09:55 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Nemo 2013-07-11 09:48:03 UTC 
Last "Change abandoned" on 2013-06-27:
[12:48:01] <gerrit-wm_>  Change abandoned: Euvl; "(no reason)" [mediawiki/extensions/Lingo] (master) - https://gerrit.wikimedia.org/r/70807

Last event with inline comments but no cover review on 2013-06-29:
[20:56:52] <gerrit-wm_>  New review: Mwjames; "(1 comment)" [mediawiki/extensions/SemanticInternalObjects] (master) - https://gerrit.wikimedia.org/r/67590

(Grepping curl http://bots.wmflabs.org/~wm-bot/logs/%23wikimedia-dev/%23wikimedia-dev.tar.gz | tar -xzf - )
Comment 1 Nemo 2013-07-11 10:49:54 UTC 
(In reply to comment #0)
> Last event with inline comments but no cover review on 2013-06-29:

Scrap that, it's just the tar.gz not containing July yet... we still see "(1 comment)" events, but the last "(n comments)" event was on 2013-04-24:
[19:57:38] <gerrit-wm>   New review: Parent5446; "(7 comments)" [mediawiki/extensions/Echo] (master) C: -1;  - https://gerrit.wikimedia.org/r/60689

It surely doesn't make sense to favour 1-comment CR over multiple-comments CR, no way this can be intended.
Comment 2 Chad H. 2013-07-15 17:39:32 UTC 
Yeah, the hook changed, hadn't noticed until I was out. Will take a look.

We *really* need to rewrite these to use stream-events :(
Comment 3 Nemo 2013-07-15 17:50:23 UTC 
(In reply to comment #2)
> We *really* need to rewrite these to use stream-events :(

I hope it's not too complicated. Would that allow to solve bug 46452 too?
Comment 4 Chad H. 2013-07-15 17:51:59 UTC 
Probably would be easier.
Comment 5 Gerrit Notification Bot 2013-07-18 19:39:21 UTC 
Change 74429 had a related patch set uploaded by Demon:
Fix change-abandoned hook

https://gerrit.wikimedia.org/r/74429
Comment 6 Gerrit Notification Bot 2013-07-19 20:25:07 UTC 
Change 74429 abandoned by Demon:
Fix change-abandoned hook

Reason:
gerrit-wm is dead, long live gerrit-wm!

https://gerrit.wikimedia.org/r/74429
Comment 7 Chad H. 2013-07-23 22:37:40 UTC 
Change abandoned has been fixed. +2 inline comments I dunno...how does the bot handle those now?
Comment 8 Nemo 2013-07-27 16:43:47 UTC 
(In reply to comment #7)
> +2 inline comments I dunno...how does the
> bot
> handle those now?

Might be working, tested with a 2 inline comments review:
18.42 < grrrit-wm> (CR) Nemo bis: "(2 comments)" [core] - https://gerrit.wikimedia.org/r/76289 (owner: Nemo bis)
Comment 9 Antoine "hashar" Musso (WMF) 2013-11-19 09:55:16 UTC 
Seems to be working for me. I got abandoned and +2 notifications recently.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links