Last modified: 2013-09-09 22:30:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T53065, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 51065 - VisualEditor: Link editor requires ENTER for input
VisualEditor: Link editor requires ENTER for input
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2013-08-15
Assigned To: Rob Moen
:
: 51177 (view as bug list)
Depends on:
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-07-09 19:34 UTC by Chris McMahon
Modified: 2013-09-09 22:30 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chris McMahon 2013-07-09 19:34:33 UTC
On any page, click Link icon

Enter text in text field

Click the "<" symbol

Check the diff or save the page.  

The link is created but the text entered is not preserved.  

Suggest either preserving the contents of the text field upon the user clicking "<" or (less nice) disabling clicking "<" until the user has hit ENTER
Comment 1 John Mark Vandenberg 2013-07-13 23:25:18 UTC
Is this still reproducible?  I tried it, and the diff was empty, but maybe I'm not following the instructions correctly.
Comment 2 Chris McMahon 2013-07-15 16:24:06 UTC
It is reproducible, let me show an example: 

Assume that the first word on a page to be edited is "ThisIsALinkToGoogle" (no quotes) 

Open the page to be edited and without doing anything else to the page, click the Link icon.  The Link dialog shows ThisIsALinkToGoogle highlighted and entered automatically in the text field input. 

In the input field, replace ThisIsALinkToGoogle by typing "http://www.google.com"

When you finish typing, just click the left-arrow icon to close the Link dialog and (ostensibly) save what you have typed into the text field. 

Do the Save page/Review your changes dance. 

In the diff and in the saved page you will see 	
[[ThisIsALinkToGoogle]] which is not helpful.  

What I would expect to see is your typing preserved in a link like [http://www.google.com ThisIsALinkToGoogle]
Comment 3 Chris McKenna 2013-07-22 18:57:50 UTC
Is this the same thing as bug 48789?
Comment 4 John Mark Vandenberg 2013-07-22 22:09:48 UTC
OK, my apologies.  I can reproduce with those steps.

Bug 48789 looks more like a UI design 'enhancement', whereas this bug is a simple bugfix for the current design.
Comment 5 Gerrit Notification Bot 2013-07-30 22:06:54 UTC
Change 76839 had a related patch set uploaded by Trevor Parscal:
The greatest commit in the history of the world*

https://gerrit.wikimedia.org/r/76839
Comment 6 Gerrit Notification Bot 2013-07-31 20:54:48 UTC
Change 76839 merged by jenkins-bot:
Link inspector bug fixes

https://gerrit.wikimedia.org/r/76839
Comment 7 James Forrester 2013-07-31 21:08:33 UTC
This is now merged and will be deployed later.
Comment 8 James Forrester 2013-08-30 03:54:25 UTC
*** Bug 51177 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links