Last modified: 2014-02-22 16:56:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52910, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50910 - VisualEditor: CE CSS munging issue with specific (highly used) hewiki template
VisualEditor: CE CSS munging issue with specific (highly used) hewiki template
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-01-09
Assigned To: Moriel Schottlender
:
Depends on: 53436
Blocks: ve-rtl ve-nonenglish
  Show dependency tree / graph
 
Reported: 2013-07-07 22:22 UTC by Moriel Schottlender
Modified: 2014-02-22 16:56 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Moriel Schottlender 2013-07-07 22:22:57 UTC 
Reproduce:

1. Go to this page: https://he.wikipedia.org/wiki/%D7%A9%D7%9C%D7%9E%D7%94_%D7%A4%D7%99%D7%9C%D7%91%D7%A8 (Image is floating on the left)

2. Edit the page. The image is now stretched all across the content area, pushing the text down.

This is a 'no picture existing' template. In the Hebrew wiki: https://he.wikipedia.org/wiki/%D7%AA%D7%91%D7%A0%D7%99%D7%AA:%D7%90%D7%99%D7%9F_%D7%AA%D7%9E%D7%95%D7%A0%D7%94

It is probably an issue of the template code, but since it's used very often, it would be great if someone can help find the problem in this so we can fix the template itself.
Comment 1 James Forrester 2014-01-05 10:57:46 UTC 
Was this fixed by the fix for bug 53436?
Comment 2 Moriel Schottlender 2014-01-05 17:11:51 UTC 
Ah! Partially. The image is no longer spread wide, but it floats the wrong way - it should float to the left, but it floats to the right inside VE.
Comment 3 Moriel Schottlender 2014-01-05 17:38:04 UTC 
I found the remaining issue - since the page (and transclusion div) is set to dir='rtl' the "mw-halign-left" class float:left turned to float:right. 

This is quite odd, since these classes have /*@noflip*/ on them.
Comment 4 Gerrit Notification Bot 2014-01-06 07:02:29 UTC 
Change 105640 had a related patch set uploaded by Mooeypoo:
Force CSSJanus to not flip image alignment classes

https://gerrit.wikimedia.org/r/105640
Comment 5 Gerrit Notification Bot 2014-01-06 07:45:13 UTC 
Change 105639 had a related patch set uploaded by Catrope:
Support attribute selectors in CSSJanus

https://gerrit.wikimedia.org/r/105639
Comment 6 Gerrit Notification Bot 2014-01-07 02:45:56 UTC 
Change 105640 merged by jenkins-bot:
Force CSSJanus to not flip image alignment classes

https://gerrit.wikimedia.org/r/105640
Comment 7 Gerrit Notification Bot 2014-02-22 16:56:30 UTC 
Change 105639 merged by jenkins-bot:
CSSJanus: Account for attribute selectors in brace lookahead

https://gerrit.wikimedia.org/r/105639
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links