Last modified: 2014-02-22 16:56:30 UTC
Reproduce: 1. Go to this page: https://he.wikipedia.org/wiki/%D7%A9%D7%9C%D7%9E%D7%94_%D7%A4%D7%99%D7%9C%D7%91%D7%A8 (Image is floating on the left) 2. Edit the page. The image is now stretched all across the content area, pushing the text down. This is a 'no picture existing' template. In the Hebrew wiki: https://he.wikipedia.org/wiki/%D7%AA%D7%91%D7%A0%D7%99%D7%AA:%D7%90%D7%99%D7%9F_%D7%AA%D7%9E%D7%95%D7%A0%D7%94 It is probably an issue of the template code, but since it's used very often, it would be great if someone can help find the problem in this so we can fix the template itself.
Was this fixed by the fix for bug 53436?
Ah! Partially. The image is no longer spread wide, but it floats the wrong way - it should float to the left, but it floats to the right inside VE.
I found the remaining issue - since the page (and transclusion div) is set to dir='rtl' the "mw-halign-left" class float:left turned to float:right. This is quite odd, since these classes have /*@noflip*/ on them.
Change 105640 had a related patch set uploaded by Mooeypoo: Force CSSJanus to not flip image alignment classes https://gerrit.wikimedia.org/r/105640
Change 105639 had a related patch set uploaded by Catrope: Support attribute selectors in CSSJanus https://gerrit.wikimedia.org/r/105639
Change 105640 merged by jenkins-bot: Force CSSJanus to not flip image alignment classes https://gerrit.wikimedia.org/r/105640
Change 105639 merged by jenkins-bot: CSSJanus: Account for attribute selectors in brace lookahead https://gerrit.wikimedia.org/r/105639
