Last modified: 2014-03-04 13:32:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52890, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 50890 - Various links to special pages are not constructed correctly


Summary:	Various links to special pages are not constructed correctly

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:	need-volunteer

Depends on:
Blocks:	code_quality
	Show dependency tree / graph

Reported:	2013-07-07 16:29 UTC by Liangent
Modified:	2014-03-04 13:32 UTC (History)
CC List:	4 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Liangent 2013-07-07 16:29:02 UTC

I noticed various calls like

$specialPage->getTitle()->getLocalURL() . '/' . $subpage

in Wikibase codebase which should be written as

$specialPage->getTitle( $subpage )->getLocalURL()

Comment 1 Gerrit Notification Bot 2014-02-21 13:09:05 UTC

Change 114741 had a related patch set uploaded by Tobias Gritschacher:
Correct usage of getLocalURL

https://gerrit.wikimedia.org/r/114741

Comment 2 Gerrit Notification Bot 2014-02-21 14:30:21 UTC

Change 114741 merged by jenkins-bot:
Correct usage of getLocalURL

https://gerrit.wikimedia.org/r/114741

Comment 3 Gerrit Notification Bot 2014-02-21 15:51:09 UTC

Change 114751 had a related patch set uploaded by Tobias Gritschacher:
Correctly construct edit-links to SpecialPages in EntityView

https://gerrit.wikimedia.org/r/114751

Comment 4 Gerrit Notification Bot 2014-02-24 11:03:59 UTC

Change 114751 merged by jenkins-bot:
Correctly construct edit-links to SpecialPages in EntityView

https://gerrit.wikimedia.org/r/114751

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links