Last modified: 2014-10-23 19:29:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52881, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50881 - VisualEditor: Link input widget should suggest section links
VisualEditor: Link input widget should suggest section links
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
: 51118 51121 51445 61428 (view as bug list)
Depends on: 53219
Blocks: ve-linkediting
  Show dependency treegraph
 
Reported: 2013-07-07 05:05 UTC by Robin Green
Modified: 2014-10-23 19:29 UTC (History)
10 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robin Green 2013-07-07 05:05:14 UTC
When I edited an internal link and pasted in Work_breakdown_structure#Terminal_element as the new link target, the link editor widget thought that it was a new page, because it didn't understand that the # referenced an anchor within that page.

However, that was just a harmless warning - it did work. So I am classifying this as minor severity, because it is merely an incorrect warning message that could confuse editors.
Comment 1 James Forrester 2013-07-10 16:51:54 UTC
* The link inspector needs to understand that if Foo exists, linking to Foo#Bar isn't a red link
* Ideally the link inspector should have introspection of articles' sections so that it can suggest which headings to link to
* This should also work for naked (local) section links - i.e., linking to just #Bar on the local page.
Comment 2 James Forrester 2013-07-10 16:52:18 UTC
*** Bug 51118 has been marked as a duplicate of this bug. ***
Comment 3 Chris McKenna 2013-07-10 17:12:16 UTC
When reporting the duplicate bug (sorry, this one didn't come up in my search) I wondered whether this was related to Bug 33094
Comment 4 James Forrester 2013-07-11 04:52:55 UTC
(In reply to comment #3)
> When reporting the duplicate bug (sorry, this one didn't come up in my
> search)

Don't worry, it's my fault for not triaging earlier. :-)

> I wondered whether this was related to Bug 33094

I don't believe so (though we should get that fixed soon too, of course).
Comment 5 James Forrester 2013-07-11 05:23:14 UTC
*** Bug 51121 has been marked as a duplicate of this bug. ***
Comment 6 Chris McKenna 2013-07-11 07:08:45 UTC
Worth noting here the comments on bug 50945 about cases where display text != link text (piped links)
Comment 7 John Broughton 2013-07-16 16:20:18 UTC
This isn't just a display problem, and it is NOT an enhancement - it's a real defect because editors are unlikely to take the time - as I did - to figure out how to make section links work.

Here's what happens now: The editor finds an article to link to (good UI; much better than the wikitext editor); then he/she starts typing the section link (#whatever). The link name turns red (that's the display issue), and it doesn't suggest section names (that would be a really slick enhancement; if you do this well, people are going to love you). Instead, when the editor is done typing the section information, one of four things can happen:

* The editor presses Enter/Return (per the user guide), and the section information is REMOVED by VE. That is clearly a defect in the software.

* The editor presses the close icon (<) (per the user guide), and the section information is REMOVED by VE. That is clearly a defect in the software.

* The editor clicks somewhere else on the page, and the section information is REMOVED by VE. That is clearly a defect in the software.

* The editor clicks on the area ABOVE the input box, the area containing the word "Hyperlink", and VE is happy, and saves the section information. (I'm going to add that to the user guide, but that wouldn't do nearly as much good as changing, in the software, what happens in the first three situations, above.
Comment 8 Keegan Peterzell 2013-07-17 02:51:13 UTC
*** Bug 51445 has been marked as a duplicate of this bug. ***
Comment 9 Elitre 2013-08-05 21:55:03 UTC
The suggestion of the sections that can be linked are also requested at it.wp.
Comment 10 John Broughton 2013-08-06 20:46:46 UTC
The VE software has changed (at least a week ago, maybe longer) for this issue. Now pressing [Return] does not remove the "#Whatever" text that the user typed, for the section link. So this bug is now primarily a display issue.

(In reply to comment #7)
> This isn't just a display problem, and it is NOT an enhancement - it's a real
> defect because editors are unlikely to take the time - as I did - to figure
> out
> how to make section links work.
> 
> Here's what happens now: The editor finds an article to link to (good UI;
> much
> better than the wikitext editor); then he/she starts typing the section link
> (#whatever). The link name turns red (that's the display issue), and it
> doesn't
> suggest section names (that would be a really slick enhancement; if you do
> this
> well, people are going to love you). Instead, when the editor is done typing
> the section information, one of four things can happen:
> 
> * The editor presses Enter/Return (per the user guide), and the section
> information is REMOVED by VE. That is clearly a defect in the software.
> 
> * The editor presses the close icon (<) (per the user guide), and the section
> information is REMOVED by VE. That is clearly a defect in the software.
> 
> * The editor clicks somewhere else on the page, and the section information
> is
> REMOVED by VE. That is clearly a defect in the software.
> 
> * The editor clicks on the area ABOVE the input box, the area containing the
> word "Hyperlink", and VE is happy, and saves the section information. (I'm
> going to add that to the user guide, but that wouldn't do nearly as much good
> as changing, in the software, what happens in the first three situations,
> above.
Comment 11 Elitre 2013-08-22 11:23:22 UTC
John reports today that "It used to be possible, in VE, to link to another section of a page (say, Bank#History). Now, when section information is added, in the Link/Hyperlink dialog box, VE just deletes it when the user presses [return] or exits (in any way) that dialog box."
Comment 12 Chris McKenna 2013-08-26 14:34:25 UTC
(In reply to comment #11)
> John reports today that "It used to be possible, in VE, to link to another
> section of a page (say, Bank#History). Now, when section information is
> added,
> in the Link/Hyperlink dialog box, VE just deletes it when the user presses
> [return] or exits (in any way) that dialog box."

Noting for posterity that that was bug 53219, which has now been fixed.
Comment 13 James Forrester 2014-05-30 02:34:40 UTC
*** Bug 61428 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links