Last modified: 2013-07-05 19:51:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52731, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50731 - VisualEditor: [Regression] Section edit links have reverted to the old style (source only, not expanded)
VisualEditor: [Regression] Section edit links have reverted to the old style ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2013-07-11
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-04 09:44 UTC by Guillaume Paumier
Modified: 2013-07-05 19:51 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screenshot (76.67 KB, image/png)
2013-07-04 09:44 UTC, Guillaume Paumier
Details

Description Guillaume Paumier 2013-07-04 09:44:28 UTC
Created attachment 12752 [details]
screenshot

As of today, the section edit links seem to have reverted to the old style ([edit]). They don't expand and they open the source editor, even though VE is enabled (the 'Edit' and 'Edit source' tabs are there at the top. See screenshot.

Observed on en.wp (by me and User:KTC) and fr.wp (by me). KTC used firefox and chrome, and I used firefox 21.
Comment 1 David Gerard 2013-07-04 15:25:40 UTC
I'd call this NOTABUG, since James has declared that visual section-editing won't be funded for the foreseeable future. So we now don't have an interface that claims functionality there aren't even plans to implement.
Comment 2 Guillaume Paumier 2013-07-04 15:40:31 UTC
Well, if that's the case (I haven't heard about it, but I believe you) presumably the link should be renamed to "edit source" to be consistent with the naming of the tabs. Otherwise, I expect quite a bit of confusion.
Comment 3 David Gerard 2013-07-04 15:43:44 UTC
Bug 48429#c35 - basically, visual section editing is a seriously hard problem, and isn't on the agenda any time soon.
Comment 4 Erik Moeller 2013-07-04 20:21:55 UTC
Bizarrely, the mouseover "edit source" links appear briefly when mousing over "edit" links while VE is loading a page into edit mode.
Comment 5 Gerrit Notification Bot 2013-07-05 06:02:05 UTC
Change 72069 had a related patch set uploaded by Krinkle:
mw.ViewPageTarget.init: Move edit section to top init.

https://gerrit.wikimedia.org/r/72069
Comment 6 Eduard Braun 2013-07-05 09:22:15 UTC
Please consider fixing bug 50540 and maybe bug 50405, too.

They are directly dependent of this change. Fixing them now once and for all will prevent further hassle with changing editsection links back-and-forth.

Actually fixing bug 50540 would probably simplify code a lot and could therefore resolve bug 50405 as a side effect.
Comment 7 Gerrit Notification Bot 2013-07-05 18:40:17 UTC
Change 72069 merged by jenkins-bot:
mw.ViewPageTarget.init: Move edit section to top init

https://gerrit.wikimedia.org/r/72069
Comment 8 James Forrester 2013-07-05 19:51:32 UTC
Merged and will hopefully go out soon.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links