Last modified: 2013-08-01 09:56:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52729, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50729 - Handle exception in LangLinkHandler when sites not found
Handle exception in LangLinkHandler when sites not found
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataClient (Other open bugs)
master
All All
: Unprioritized major (vote)
: ---
Assigned To: Aude
:
Depends on:
Blocks: 51699
  Show dependency treegraph
 
Reported: 2013-07-04 09:30 UTC by Aude
Modified: 2013-08-01 09:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2013-07-04 09:30:44 UTC
Currently, the client fails hard with an exception if the sites table is empty or a site not found.

Exception from line 463 of
/data/project/apache/common-local/php-master/extensions/Wikibase/client/includes/LangLinkHandler.php:
Unable to resolve site ID 'enwiki'!

We need to handle this more gracefully and at the same time log it in a prominent way that we are sure to be notified and aware.

An unknown site id could happen, for example, if there is a new wikipedia added and the sites data is not synched fully yet across the clients and repo, among other plausible scenarios.
Comment 1 Gerrit Notification Bot 2013-07-20 07:23:52 UTC
Change 74829 had a related patch set uploaded by Aude:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/74829
Comment 2 Gerrit Notification Bot 2013-07-20 09:50:26 UTC
Change 74829 merged by jenkins-bot:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/74829
Comment 3 Antoine "hashar" Musso (WMF) 2013-07-22 11:15:45 UTC
That apparently fixed the wiki creation stack trace I had in bug 51699.
Comment 4 Gerrit Notification Bot 2013-07-23 18:16:09 UTC
Change 75369 had a related patch set uploaded by Aude:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/75369
Comment 5 Gerrit Notification Bot 2013-07-23 18:17:19 UTC
Change 75369 merged by Aude:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/75369
Comment 6 Gerrit Notification Bot 2013-07-23 18:23:22 UTC
Change 75371 had a related patch set uploaded by Aude:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/75371
Comment 7 Gerrit Notification Bot 2013-07-23 18:23:38 UTC
Change 75371 merged by Hoo man:
(bug 50729, bug 51699) handle exception in the langlinkhander

https://gerrit.wikimedia.org/r/75371
Comment 8 Antoine "hashar" Musso (WMF) 2013-07-24 19:26:34 UTC
That fixed the addWiki issue I was encountering so I guess we are fine now.
Comment 9 abraham.taherivand 2013-08-01 09:56:22 UTC
Verified in Wikidata demo July 31th.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links