Last modified: 2013-07-04 01:37:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52677, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50677 - VisualEditor: Init loads oo.js on every page view (before browser blacklist) which throws an error in IE10 + compatibility mode
VisualEditor: Init loads oo.js on every page view (before browser blacklist) ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2013-07-04
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-03 17:23 UTC by Derk-Jan Hartman
Modified: 2013-07-04 01:37 UTC (History)
4 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Derk-Jan Hartman 2013-07-03 17:23:13 UTC
On every page I load on IE10, when switched into compatibility mode, I currently get the following error.

oo.js, line 97 character 2
Object doesn't support property or method 'create'

Also, if VE is not enabled on IE10, then why is this code being loaded ?
Comment 1 Roan Kattouw 2013-07-03 19:10:12 UTC
(In reply to comment #0)
> On every page I load on IE10, when switched into compatibility mode, I
> currently get the following error.
> 
> oo.js, line 97 character 2
> Object doesn't support property or method 'create'
> 
Object.create and other ES5 features are only supported in IE10 and up, so IE10 in compat mode does not support them.

> Also, if VE is not enabled on IE10, then why is this code being loaded ?
Unfortunately, the blacklisting code is in a class, and that class extends another class, and oo.extendClass() uses Object.create() :(

We're working on fixing this by moving the blacklisting up, see bug 50612
Comment 2 James Forrester 2013-07-03 19:11:59 UTC
This code shouldn't be running before the browser blacklists, you're right. We need to fix this urgently to avoid so many errors for users on every page load.

To avoid confusion, note that this code works fine in "real" IE10, just not in compatibility mode; this isn't a blocker for VE working in IE.
Comment 3 James Forrester 2013-07-03 19:33:35 UTC
Reclassifying as not serious after feedback confirming this only happens in developer mode.
Comment 4 James Forrester 2013-07-04 01:37:07 UTC
But now fixed in production anyway. :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links