Last modified: 2013-06-30 02:01:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52417, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50417 - VisualEditor does not load on Opera when debugging with Dragonfly
VisualEditor does not load on Opera when debugging with Dragonfly
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Unprioritized normal
: VE-deploy-2013-07-04
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks: 36000
  Show dependency treegraph
 
Reported: 2013-06-29 12:05 UTC by Bartosz Dziewoński
Modified: 2013-06-30 02:01 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2013-06-29 12:05:24 UTC
Would you believe that.

[6/29/2013 1:44:17 PM] JavaScript - https://pl.wikipedia.org/wiki/Gródek_(obwód_lwowski)?veaction=edit
Event thread: readystatechange
Uncaught exception: Error: WRONG_ARGUMENTS_ERRError thrown at line 39, column 4 in <anonymous function: ve.copyDomElements>(domElement) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.base%2Cmediawiki%2CviewPageTarget%7Cjquery.visibleText%7Coojs%7Cunicodejs.wordbreak&skin=vector&version=20130629T021004Z&*:
    return doc ? doc.importNode(domElement, true) : domElement.cloneNode(true);
called from line 38, column 3 in <anonymous function: ve.copyDomElements>(domElements, doc) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.base%2Cmediawiki%2CviewPageTarget%7Cjquery.visibleText%7Coojs%7Cunicodejs.wordbreak&skin=vector&version=20130629T021004Z&*:
    return domElements.map(function(domElement) {
called from line 9721, column 3 in <anonymous function: ve.ce.GeneratedContentNode.prototype.onUpdate>() in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    this.$.empty().append(ve.copyDomElements(store.value(index), doc));
called from line 9711, column 2 in VeCeGeneratedContentNode() in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    this.onUpdate();
called via Function.prototype.call() from line 10325, column 2 in VeCeMWTransclusionNode(model, config) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    ve.ce.GeneratedContentNode.call(this);
called via Function.prototype.call() from line 10366, column 2 in VeCeMWTransclusionBlockNode(model) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    ve.ce.MWTransclusionNode.call(this, model);
called via Function.prototype.apply() from line 50, column 2 in <anonymous function: ve.Factory.prototype.create>(name) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    constructor.apply(obj, args);
called from line 8132, column 4 in <anonymous function: ve.ce.BranchNode.prototype.onSplice>(index) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    args[i] = ve.ce.nodeFactory.create(args[i].getType(), args[i]);
called via Function.prototype.apply() from line 8089, column 2 in VeCeBranchNode(model, config) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    this.onSplice.apply(this, [0, 0].concat(model.getChildren()));
called via Function.prototype.call() from line 9824, column 2 in VeCeDocumentNode(model, surface, config) in https://bits.wikimedia.org/pl.wikipedia.org/load.php?debug=false&lang=pl&modules=ext.visualEditor.core%2Cicons-vector%7Cext.visualEditor.viewPageTarget.icons-vector%7Crangy&skin=vector&version=20130629T021004Z&*:
    ve.ce.BranchNode.call(this, model, config);

At this point `store.value(index)` is [undefined, undefined] on Opera, but [<span...>, <dl...>] on Firefox. Since `index` is not undefined, this would indicate some sort of an internal inconsistency.
Comment 1 Bartosz Dziewoński 2013-06-29 12:21:13 UTC
Hey, it's even better – all of the arrays in store.valueStore apparently consist only of varying number of undefineds.
Comment 2 Bartosz Dziewoński 2013-06-29 12:26:55 UTC
And this is because ve.copyArray() is losing data, always returning an array of undefineds there.
Comment 3 Bartosz Dziewoński 2013-06-29 12:34:37 UTC
And that is because #cloneNode is returning `undefined` for those elements (probably because they come from some weird dynamically-generated document). Which is clearly an Opera bug, but it'd be nice to work around it somehow.
Comment 4 Bartosz Dziewoński 2013-06-29 12:46:02 UTC
I know why it only fails when debugging: because the fix in https://gerrit.wikimedia.org/r/#/c/61560/ is only applied when not debugging. Apparently the document there is *still* not a document evenif it appears to be one.
Comment 5 Gerrit Notification Bot 2013-06-29 13:02:24 UTC
Change 71174 had a related patch set uploaded by Matmarex:
Make loading VE work on Opera again, attempt two

https://gerrit.wikimedia.org/r/71174
Comment 6 Gerrit Notification Bot 2013-06-30 01:47:31 UTC
Change 71174 merged by jenkins-bot:
Make loading VE work on Opera again, attempt two

https://gerrit.wikimedia.org/r/71174

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links