Last modified: 2014-09-14 13:07:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52105, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 50105 - VisualEditor: IME shift+ function for adding diacritical marks in Arabic broken
VisualEditor: IME shift+ function for adding diacritical marks in Arabic broken
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Language (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2013-08-22
Assigned To: D Chan
:
Depends on:
Blocks: ve-multi-lingual
  Show dependency treegraph
 
Reported: 2013-06-24 15:31 UTC by Patrick Earley
Modified: 2014-09-14 13:07 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Patrick Earley 2013-06-24 15:31:36 UTC
From http://www.mediawiki.org/wiki/Thread:VisualEditor/Feedback/Problem_with_using_shift%2B

"Hi. I have been using the visual editor for a while on ar Wikipedia, it is very nice and smooth for fast edits. However, I am facing a very strange problem when I need to add some Arabic diacritics known as tashkil; when I press shift+diacritic button (like x, e, or z) the letter I pressed starts to repeat itself endlessly, and it can only be stopped by refreshing the page and wasting the work I have did. Any thoughts?"
Comment 1 James Forrester 2013-06-24 16:13:32 UTC
Bumping priority, moving module, assigning, slight rewording; note that we can't fix things in the past (;-)), so setting to next week's deployment deadline.
Comment 2 Patrick Earley 2013-06-24 16:15:21 UTC
Thanks James - first bug report.
Comment 3 James Forrester 2013-06-24 16:19:25 UTC
(In reply to comment #2)
> Thanks James - first bug report.

No worries. :-) Welcome to the party.
Comment 4 D Chan 2013-08-19 18:19:49 UTC
I think this may be resolved by the following patch:
https://gerrit.wikimedia.org/r/#/c/79451 . It fixes similar bugs in other scripts with similar properties.

If it's still broken, is it possible to give a specific example of:

1. A piece of Arabic text where VisualEditor fails
2. The keystrokes required to enter the text
3. The incorrect output observed in VisualEditor
4. The OS, browser and input method used.

Thanks!
Comment 5 Gerrit Notification Bot 2013-08-20 19:41:16 UTC
Change 80080 had a related patch set uploaded by Jforrester:
WIP:Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
Comment 6 Abbad 2013-08-20 22:24:17 UTC
Thank you. I have tested all possible diacritics on Arabic Wikipedia and everything is working great. Good job!
Comment 7 Gerrit Notification Bot 2013-08-22 09:48:40 UTC
Change 80080 merged by jenkins-bot:
Don't emit Surface changes back to the Surface

https://gerrit.wikimedia.org/r/80080
Comment 8 James Forrester 2013-08-22 20:12:28 UTC
Given that this is now merged, I'm going to mark this as fixed. However, this is provisional - please re-open if you think that this has not worked!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links