Last modified: 2014-02-27 18:38:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51866, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49866 - VisualEditor: Transclusion editor shows empty "content" sections for newlines
VisualEditor: Transclusion editor shows empty "content" sections for newlines
Status: RESOLVED WORKSFORME
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-templatesupport
  Show dependency treegraph
 
Reported: 2013-06-20 09:54 UTC by This, that and the other (TTO)
Modified: 2014-02-27 18:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description This, that and the other (TTO) 2013-06-20 09:54:39 UTC
1. Go to [[Ahab]] and edit in VE
2. Select the succession box at the bottom and edit with transclusion editor
3. Observe that "content" sections are present that look blank, but on closer inspection, contain only a newline

Some templates (like succession boxes) unfortunately need to be on separate lines in the wikitext :( But the current UI for this is non-obvious and could be made better.
Comment 1 James Forrester 2013-06-21 00:45:21 UTC
Yeah, this is a bit of a mess. We could get Parsoid to /always/ do a newline between templates of the same generated block, I suppose? Gabriel, thoughts?
Comment 2 Gabriel Wicke 2013-06-21 01:14:48 UTC
This is the exact wikitext that is interspersed between template calls, so follows our DOM spec (see http://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Template_content). 

The decision whether that should be presented in the UI is one for the VisualEditor team to make. Non-whitespace content like '|-' for a new table row is probably important to show, while pure ws could also be hidden from view.
Comment 3 James Forrester 2014-02-27 18:38:13 UTC
The work-around that Parsoid did to hide these means that these don't appear unless it's mis-matched, which is reasonable enough that I'm going to flag as WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links