Last modified: 2013-08-30 22:01:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51778, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49778 - VisualEditor: Template dialog should look up TemplateData for newly-added templates
VisualEditor: Template dialog should look up TemplateData for newly-added tem...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2013-07-04
Assigned To: Trevor Parscal
:
Depends on:
Blocks: ve-templatesupport
  Show dependency treegraph
 
Reported: 2013-06-18 21:53 UTC by James Forrester
Modified: 2013-08-30 22:01 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description James Forrester 2013-06-18 21:53:14 UTC
Currently in the template dialog when you insert a new template (or other transclusion) it doesn't look up TemplateData for said template (but re-uses if available). It should.
Comment 1 Oliver Keyes 2013-06-28 09:29:46 UTC
Any movement on this? I note the milestone was yesterday's deploy (if it went out but got reverted with the wmf7 problems, ignore me).
Comment 2 Gerrit Notification Bot 2013-06-28 21:38:49 UTC
Change 71132 had a related patch set uploaded by Trevor Parscal:
Use template data for new templates

https://gerrit.wikimedia.org/r/71132
Comment 3 Gerrit Notification Bot 2013-06-28 23:36:42 UTC
Change 71132 merged by jenkins-bot:
Use template data for new templates and fix alias bug

https://gerrit.wikimedia.org/r/71132
Comment 4 James Forrester 2013-06-28 23:39:34 UTC
Done in the above commit.
Comment 5 Carl Fürstenberg 2013-06-29 23:17:33 UTC
Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to persist:

First I make a new template instance and file one parameter:
http://i.imgur.com/69K7IcD.png

Notice the lack of information

Next I apply changes, and open the template dialog again, and following is shown:
http://i.imgur.com/hV8rqag.png
Comment 6 se4598 2013-06-29 23:34:41 UTC
(In reply to comment #5)
> Testing on beta, which is using 1.22alpha (3c4aac9) the issue seems to

This is mediawiki-core. VisualEditor at beta.wmflabs should be currently at f8d2f14 (latest; including merged commit) after Reedy manually updated it (again).
Comment 7 Carl Fürstenberg 2013-06-30 00:55:11 UTC
Seems to have been some cache issues, because it seems to be fine now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links