Last modified: 2013-07-11 22:43:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51602, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49602 - VisualEditor: Show VisualEditor tag in diffs
VisualEditor: Show VisualEditor tag in diffs
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2013-07-11
Assigned To: James Forrester
:
Depends on: 25824
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-15 01:15 UTC by Matthew Flaschen
Modified: 2013-07-11 22:43 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-06-15 01:15:59 UTC
The VisualEditor edit tag (Tag: VisualEditor) should show on diffs, too.  This will probably require a core change.  However, I'm filing it here, both so you're aware of it, and because it might need to be configurable (it might be we don't want all tags, such as AbuseFilter, etc. to show on diffs).
Comment 1 James Forrester 2013-06-16 21:52:44 UTC
Core change request created as bug 49656. Until that's done this is a "later", sadly.
Comment 2 Gerrit Notification Bot 2013-07-06 21:03:42 UTC
Change 72317 had a related patch set uploaded by Matmarex:
Show change tags on diffs

https://gerrit.wikimedia.org/r/72317
Comment 3 Bartosz Dziewoński 2013-07-06 21:15:20 UTC
(In reply to comment #0)
> because it might need to be configurable (it might be
> we don't want all tags, such as AbuseFilter, etc. to show on diffs).

Personally I see no reason to show any tag in history view, but keep it hidden on diff view. What would be the use case?
Comment 4 Matthew Flaschen 2013-07-06 22:45:36 UTC
(In reply to comment #3)
> Personally I see no reason to show any tag in history view, but keep it
> hidden on diff view. What would be the use case?

It might be annoying to have AbuseFilter tags exposed on the diff UI, since they are known to sometimes be inaccurate (like any automatic classification).  When you're looking at the diff, you see the full change, so automatic classifications are less necessary.

However, I think it's reasonable to just show all the tags for now, and revisit if it turns out to be an issue in practice.
Comment 5 MZMcBride 2013-07-07 01:54:48 UTC
(In reply to comment #3)
> Personally I see no reason to show any tag in history view, but keep it
> hidden on diff view. What would be the use case?

Because revision tagging is really incomplete, as I recall, lacking the ability to do all the things you might want to do with revision tags (like manually adding one, removing an incorrect one, renaming one, etc.).

Matthew also brings up another major point in comment 4. Historically revision tags have been added with AbuseFilter filters (Andrew G. wrote both the AbuseFilter extension and the core revision tagging feature, as I remember it). Consequently, making "possible libel" or other similar tags more visible in the user interface may not be a great idea until revision tagging is further developed.
Comment 6 Bartosz Dziewoński 2013-07-07 19:48:12 UTC
(In reply to comment #5)
> Because revision tagging is really incomplete, as I recall, lacking
> the ability to do all the things you might want to do with revision
> tags (like manually adding one, removing an incorrect one, renaming
> one, etc.).

File a bug :) Change I8ace1d47 (now abandoned) attempted to add an API
module for this, it could be used as a starting point.


(In reply to comment #5)
> Matthew also brings up another major point in comment 4.
> Historically revision tags have been added with AbuseFilter filters
> (Andrew G. wrote both the AbuseFilter extension and the core
> revision tagging feature, as I remember it). Consequently, making
> "possible libel" or other similar tags more visible in the user
> interface may not be a great idea until revision tagging is further
> developed.

They are not really *that* visible, they're displayed just like edit
summaries, but without the italics. (Of course wiki admins can make
them show up all uppercase, bold and on neon-yellow background.)
Comment 7 Gerrit Notification Bot 2013-07-10 19:07:22 UTC
Change 72317 merged by jenkins-bot:
Show change tags on diffs

https://gerrit.wikimedia.org/r/72317
Comment 8 James Forrester 2013-07-10 20:00:07 UTC
The core change is done in MW master, and will be part of wmf10; as such, marking this as fixed.
Comment 9 Gerrit Notification Bot 2013-07-11 22:43:36 UTC
Change 73004 merged by jenkins-bot:
Remove "Tag: " prefix, now that they're in MW core

https://gerrit.wikimedia.org/r/73004

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links