Last modified: 2014-07-02 13:48:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51538, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 49538 - Cite: Improve compatibility between Parsoid's port and the PHP extension
Cite: Improve compatibility between Parsoid's port and the PHP extension
Status: NEW
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: Marc Ordinas i Llopis
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-13 17:41 UTC by ssastry
Modified: 2014-07-02 13:48 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-06-13 17:41:59 UTC
* Several error checks that the PHP Cite extension does are not performed in Parsoid's cite impl.

-- nested ref tags are erroneous
-- if group is set on <references>, one should be set on all refs defined 
   in references-body
-- only one group param, and one name/follow param.
-- For ref in references body, 
   - name must be present
   - content must be present
   - group should be used in main body
   - name should be used in main body
-- <ref /> is meaningless
-- nested references tags are erroneous
-- <refs> without <references /> is an error condition

* Parsoid does not support the follow arg on ref tags
Comment 1 Andre Klapper 2013-07-04 10:33:23 UTC
[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]
Comment 2 Carl Fürstenberg 2013-07-23 22:21:47 UTC
Per http://www.mediawiki.org/wiki/Extension:Cite/Cite.php#Merging_two_texts_into_a_single_reference_.28wikisource_issue.29

"<ref name"foo">blablabla</ref> yamamamam <ref follow="foo"><br/>chawachawa</ref>"

should create a single ref with both texts in it
Comment 3 C. Scott Ananian 2013-08-12 16:36:16 UTC
We should also probably try to run upstream's mediawiki/extensions/Cite/citeParserTests.txt.

Note also that bug 2700 seems to have the PST run on the body of the <ref> and <references> tags.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links