Last modified: 2013-09-05 09:16:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T51306, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 49306 - implement URL data type in the backend


Summary:	implement URL data type in the backend

Status:	VERIFIED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Highest enhancement (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Duplicates:	48850 (view as bug list)
Depends on:	51621
Blocks:	51109 51113
	Show dependency tree / graph

Reported:	2013-06-07 12:59 UTC by Lydia Pintscher
Modified:	2013-09-05 09:16 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Lydia Pintscher 2013-06-07 12:59:00 UTC

Implement the URL datatype.

IMPORTANT: Make sure it works nicely with abusefilter and url blacklist.

Comment 1 Daniel Kinzler 2013-07-01 12:36:22 UTC

...also, URLs need to be checked against wfUrlProtocols(). Check what the Sanitizer class does to keep evil links out.

Comment 2 Daniel Kinzler 2013-07-04 10:40:46 UTC

Requirements:

* Validate against wfUrlProtocols() on input
* Sanitize using wfUrlProtocols() etc on output
* Register as external link in ParserOutput
* Make sure it works as expected with SpamBlacklist
* Make sure it works as expected with AbuseFilter

Comment 3 Gerrit Notification Bot 2013-07-16 18:48:58 UTC

Change 73993 had a related patch set uploaded by Daniel Kinzler:
(bug 49306) introducing URL data type

https://gerrit.wikimedia.org/r/73993

Comment 4 Gerrit Notification Bot 2013-07-17 21:55:51 UTC

Change 74276 had a related patch set uploaded by Daniel Werner:
(bug 49306) Support for nicer handling of URL data type values in the frontend

https://gerrit.wikimedia.org/r/74276

Comment 5 Gerrit Notification Bot 2013-07-17 21:56:05 UTC

Change 74277 had a related patch set uploaded by Daniel Werner:
(bug 49306) valueview Expert for handling values for URL data type

https://gerrit.wikimedia.org/r/74277

Comment 6 Gerrit Notification Bot 2013-07-17 22:01:34 UTC

Change 74276 abandoned by Daniel Werner:
(bug 49306) Support for nicer handling of URL data type values in the frontend

https://gerrit.wikimedia.org/r/74276

Comment 7 Gerrit Notification Bot 2013-07-18 04:32:48 UTC

Change 73993 merged by Daniel Werner:
(bug 49306) introducing URL data type

https://gerrit.wikimedia.org/r/73993

Comment 8 Gerrit Notification Bot 2013-07-22 13:45:29 UTC

Change 74394 had a related patch set uploaded by Daniel Kinzler:
Introducing ReferencedUrlFinder

https://gerrit.wikimedia.org/r/74394

Comment 9 Daniel Kinzler 2013-07-22 13:54:20 UTC

Patches I2d26307ad4 and Ia040b891e05 (when merged) complete the backend support for the URL data type, I9ab14abc adds (basic) UI support. Together, these changes should be enough to close this ticket (even though a dedicated backend formatter is still pending).

However, for deployment, we are also blocked on bug 51621: deploying without the SpamBlacklist picking up those links would be quite bad.

Comment 10 Gerrit Notification Bot 2013-08-02 14:24:26 UTC

Change 74394 merged by jenkins-bot:
(bug 49306) Introducing ReferencedUrlFinder

https://gerrit.wikimedia.org/r/74394

Comment 11 Lydia Pintscher 2013-08-16 09:48:32 UTC

*** Bug 48850 has been marked as a duplicate of this bug. ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links