Last modified: 2013-07-08 21:23:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50912, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48912 - VisualEditor: {Ctrl,Option}+{Delete,Backspace} doesn't delete a word in an RTL wiki
VisualEditor: {Ctrl,Option}+{Delete,Backspace} doesn't delete a word in an RT...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2013-06-06
Assigned To: Moriel Schottlender
:
Depends on:
Blocks: ve-rtl 38461
  Show dependency treegraph
 
Reported: 2013-05-28 21:43 UTC by Amir E. Aharoni
Modified: 2013-07-08 21:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2013-05-28 21:43:12 UTC
Pressing Ctrl-Backspace deletes a word in a <textarea> in Firefox. It works the same way in VisualEditor when the wiki's language is English, but if it's Hebrew, it only deletes one character.

A GWT testing scenario for this would be something like this:

Given $wgLanguageCode is 'he'
        And I am editing an article
        And I wrote 'אחת שתיים שלוש'
When I press Ctrl-Backspace
Then the remaining text is 'אחת שתיים '
Comment 1 James Forrester 2013-05-28 23:13:03 UTC
This will (should?) get fixed when Inez does the re-write of this area, but assigning to Moriel to bug him and make sure he does it right. :-)
Comment 2 Moriel Schottlender 2013-06-17 23:30:47 UTC
According to my test, this was fixed, and the behavior is as predicted on my local install. It doesn't work properly in the VE that exists in he.wikipedia, so whatever was done is new.

The fact this works without fixes is incredibly weird, since the handleDelete() function uses offsets, and those are supposed to be opposite between Hebrew and English. I'm checking into potential causes, but as far as I've seen, Inez' re-implemented code works.

Amir, if you can verify this works on your local installation, that'll be helpful. I am a bit concerned about this since it doesn't make sense (it *shouldn't* work) and I am concerned that it doesn't work on he.wiki. I want to verify it isn't some local fluke before we close this bug as resolved.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links