Last modified: 2014-02-19 22:08:20 UTC
If you start with such wikitext: [[Image:Wiki.png|thumb|left|What's up?]] and you change alignment from left to right in the output you will get [[Image:Wiki.png|thumb|left|right|What's up?]] which is incorrect.
Still the case: echo '[[Image:Wiki.png|thumb|left|caption]]' | node parse | sed s/left/right/ | node parse --html2wt [[Image:Wiki.png|thumb|left|caption|right]] The plan is to introduce an internal halign shadow attribute in data-parsoid with values 'left', 'right' etc. Having a single canonical shadow attribute should make it easy to enforce mutual exclusivity.
So it seems like the mw-halign-right class, if set, should override the optList information in data-parsoid. optList is just used for round-tripping, I believe. We should probably double check all of the items in optList against the appropriate DOM pieces, and avoid re-serializing them if the DOM doesn't match.
*** Bug 56956 has been marked as a duplicate of this bug. ***
*** Bug 56957 has been marked as a duplicate of this bug. ***
Change 103068 had a related patch set uploaded by Cscott: WIP: Edited image attributes should override data-parsoid value. https://gerrit.wikimedia.org/r/103068
Change 103082 had a related patch set uploaded by Cscott: WIP: Edited image attributes should override data-parsoid value. https://gerrit.wikimedia.org/r/103082
Change 103068 abandoned by Cscott: WIP: Edited image attributes should override data-parsoid value. Reason: Rebased to new repo. https://gerrit.wikimedia.org/r/103068
Change 103082 merged by jenkins-bot: Edited image attributes should override data-parsoid value. https://gerrit.wikimedia.org/r/103082