Last modified: 2014-02-19 22:08:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50665, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48665 - Images: Parsoid duplicates image attribute after attribute value change
Images: Parsoid duplicates image attribute after attribute value change
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: C. Scott Ananian
:
: 56956 56957 (view as bug list)
Depends on:
Blocks: 54844
  Show dependency treegraph
 
Reported: 2013-05-21 01:01 UTC by Inez Korczyński
Modified: 2014-02-19 22:08 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Inez Korczyński 2013-05-21 01:01:17 UTC
If you start with such wikitext: [[Image:Wiki.png|thumb|left|What's up?]]
and you change alignment from left to right in the output you will get [[Image:Wiki.png|thumb|left|right|What's up?]] which is incorrect.
Comment 1 Gabriel Wicke 2013-06-29 04:58:07 UTC
Still the case:
echo '[[Image:Wiki.png|thumb|left|caption]]' | node parse | sed s/left/right/ | node parse --html2wt
[[Image:Wiki.png|thumb|left|caption|right]]

The plan is to introduce an internal halign shadow attribute in data-parsoid with values 'left', 'right' etc. Having a single canonical shadow attribute should make it easy to enforce mutual exclusivity.
Comment 2 C. Scott Ananian 2013-09-11 18:00:35 UTC
So it seems like the mw-halign-right class, if set, should override the optList information in data-parsoid.  optList is just used for round-tripping, I believe. We should probably double check all of the items in optList against the appropriate DOM pieces, and avoid re-serializing them if the DOM doesn't match.
Comment 3 Gabriel Wicke 2013-11-12 23:38:13 UTC
*** Bug 56956 has been marked as a duplicate of this bug. ***
Comment 4 Gabriel Wicke 2013-11-12 23:41:30 UTC
*** Bug 56957 has been marked as a duplicate of this bug. ***
Comment 5 Gerrit Notification Bot 2013-12-20 23:53:43 UTC
Change 103068 had a related patch set uploaded by Cscott:
WIP: Edited image attributes should override data-parsoid value.

https://gerrit.wikimedia.org/r/103068
Comment 6 Gerrit Notification Bot 2013-12-21 02:42:19 UTC
Change 103082 had a related patch set uploaded by Cscott:
WIP: Edited image attributes should override data-parsoid value.

https://gerrit.wikimedia.org/r/103082
Comment 7 Gerrit Notification Bot 2013-12-21 02:44:07 UTC
Change 103068 abandoned by Cscott:
WIP: Edited image attributes should override data-parsoid value.

Reason:
Rebased to new repo.

https://gerrit.wikimedia.org/r/103068
Comment 8 Gerrit Notification Bot 2014-01-08 00:40:33 UTC
Change 103082 merged by jenkins-bot:
Edited image attributes should override data-parsoid value.

https://gerrit.wikimedia.org/r/103082

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links