Last modified: 2013-06-20 00:33:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50662, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48662 - VisualEditor: Toolbar floats only down to the top of the last BranchNode (which isn't always at the end)
VisualEditor: Toolbar floats only down to the top of the last BranchNode (whi...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2013-06-20
Assigned To: Ed Sanders
:
Depends on:
Blocks: 48426
  Show dependency tree / graph
 
Reported: 2013-05-20 22:25 UTC by James Forrester
Modified: 2013-06-20 00:33 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-05-20 22:25:39 UTC 
Toolbar in VE floats to position of last BranchNode but should instead just use the bottom of the document or something.
Comment 1 Krinkle 2013-06-10 08:02:29 UTC 
So the problem is that it lets it go too far or not far enough? I can imagine it somehow, but steps to reproduce the bug would nice.
Comment 2 James Forrester 2013-06-10 17:02:21 UTC 
(In reply to comment #1)
> So the problem is that it lets it go too far or not far enough? I can imagine
> it somehow, but steps to reproduce the bug would nice.

Doesn't got far enough.

Steps to reproduce: find a document with a very long single BranchNode at the end (or create one). Use VE. Notice that the tool bar slips off the page when you get below the bottom.
Comment 3 Gerrit Notification Bot 2013-06-19 11:47:51 UTC 
Related URL: https://gerrit.wikimedia.org/r/69478 (Gerrit Change I1c7662f2b6f1ced6f80dec16c6ed69a8cc0c06c8)
Comment 4 James Forrester 2013-06-20 00:33:45 UTC 
Fix merged and will go out with next push.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links