Last modified: 2014-05-21 13:53:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50560, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48560 - VisualEditor: Category changing in page doesn't cause footer to be updated on save
VisualEditor: Category changing in page doesn't cause footer to be updated on...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-01-16
Assigned To: Ed Sanders
:
: 50072 50737 56683 57924 (view as bug list)
Depends on:
Blocks: 48426
  Show dependency tree / graph
 
Reported: 2013-05-16 23:30 UTC by James Forrester
Modified: 2014-05-21 13:53 UTC (History)
13 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-05-16 23:30:34 UTC 
Do we need to trigger a re-render of the catlinks div? Can we?
Comment 1 Krinkle 2013-06-10 08:01:34 UTC 
It depends on what we get back from the server.

If we get back something that is compatible with what api.php?action=parse gives (prop.categorieshtml, from Skin::getCategories), which is what live preview in core uses as well, then we can just update it by replacing the old with the new html.

If we can't get that, we'll have to re-implement Skin::getCategories in javascript. However I'd like to avoid that since it is skin-specific (skins can do all kinds of weird stuff to it, hard to predict. Ideally this would fall under the parts of the page output (like mw-content-text, htmlhead and script loader) that has a fixed html layout that skins can't alter the html itself of (it has enough css hooks to style anyway they like, they shouldn't need to modify the html). But that's not the reality.

--

Oh wait, this isn't from the server (not MediaWiki, not Parsoid). I mean, it shouldn't. This is reflected live when editing the document. We'll have to do it in javascript somehow I'm afraid.
Comment 2 James Forrester 2013-06-24 01:10:18 UTC 
*** Bug 50072 has been marked as a duplicate of this bug. ***
Comment 3 James Forrester 2013-07-11 15:34:35 UTC 
*** Bug 50737 has been marked as a duplicate of this bug. ***
Comment 4 James Forrester 2013-11-06 19:45:37 UTC 
*** Bug 56683 has been marked as a duplicate of this bug. ***
Comment 5 John Mark Vandenberg 2013-11-14 00:33:30 UTC 
Note that the categories on the page are not refreshed even after multiple VE sessions.  i.e. VE add category -> save -> VE add category -> save : results in a page that _displays_ only the categories at the beginning of the process.

Categories added via templates are also not displayed.
Comment 6 James Forrester 2013-12-03 16:50:49 UTC 
*** Bug 57924 has been marked as a duplicate of this bug. ***
Comment 7 Gerrit Notification Bot 2014-01-12 14:29:21 UTC 
Change 107036 had a related patch set uploaded by Esanders:
Update categories HTML on page save

https://gerrit.wikimedia.org/r/107036
Comment 8 Gerrit Notification Bot 2014-01-13 18:35:49 UTC 
Change 107036 merged by jenkins-bot:
Update categories HTML on page save

https://gerrit.wikimedia.org/r/107036
Comment 9 Rummana Yasmeen 2014-01-16 19:42:42 UTC 
Verified the fix on test 2
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links