Last modified: 2013-06-17 15:25:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50557, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48557 - Parsoid: Default whitespace for categories to be a single newline seperator between, and two beforehand
Parsoid: Default whitespace for categories to be a single newline seperator b...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
serializer (Other open bugs)
unspecified
All All
: Low trivial
: ---
Assigned To: Mark Holmquist
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-05-16 23:10 UTC by James Forrester
Modified: 2013-06-17 15:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-05-16 23:10:57 UTC 
Hope this is clear - currently:

<p>Text</p><link rel="mw:WikiLink/Category" href="./Category:Foo"><link rel="mw:WikiLink/Category" href="./Category:Bar"><link rel="mw:WikiLink/Category" href="./Category:Baz">

serialises to:

Text[[Category:Foo]][[Category:Bar]][[Category:Baz]]

and ideally we'd like:

Text

[[Category:Foo]]
[[Category:Bar]]
[[Category:Baz]]

Is this do-able? (If the two-new-lines bit is hard, happy to postpone that side.)
Comment 1 Gabriel Wicke 2013-05-16 23:36:08 UTC 
Categories are already serialized on their own line (see bug 48332). The extra newline is possible if you only add categories at the end of a document.
Comment 2 James Forrester 2013-05-16 23:42:18 UTC 
OK, I'm a fool, you'd already done most of the request in bug 48332, sorry. Re-purposing. Gabriel says that this needs us to add new categories to the end of the DOM; I think we do. Will check first.
Comment 3 Roan Kattouw 2013-06-10 20:46:59 UTC 
It looks like whitespace around categories is working properly now. The only remaining issue is whitespace around {{DEFAULTSORT}}, which needs the same rules as categories.
Comment 4 Roan Kattouw 2013-06-10 23:02:22 UTC 
https://gerrit.wikimedia.org/r/67890 also helps in preserving whitespace around existing categories and defaultsorts when we edit them.
Comment 5 Gerrit Notification Bot 2013-06-17 02:36:33 UTC 
Related URL: https://gerrit.wikimedia.org/r/69026 (Gerrit Change Ib37ccaca5ff83950742ced8f4ec3af13e81fbfab)
Comment 6 James Forrester 2013-06-17 15:25:46 UTC 
Fixed in the merged commit.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links