Last modified: 2014-06-29 20:42:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50543, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48543 - Unable to reupload revised files to Upload Wizard
Unable to reupload revised files to Upload Wizard
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
master
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
https://commons.wikimedia.org/w/index...
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-16 16:55 UTC by Jon Hunter
Modified: 2014-06-29 20:42 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Hunter 2013-05-16 16:55:54 UTC
Users on my wiki are updating files offline and would like to update the 'wiki version' of this file after their done. This normally works when you go through the built in upload tool, but I've tried to use Upload Wizard for the same function and it gives me an error message: "There is another file already on the site with the same content." I searched the bugzilla list for a solution, but didn't find a resolution. Is there a way to allow duplicate or revised files to be uploaded using this Upload Wizard?
Comment 1 Jon Hunter 2013-05-16 17:00:57 UTC
Just found an bug close to mine:
https://bugzilla.wikimedia.org/show_bug.cgi?id=40921

Could this possibly be a permissions issue?
Comment 2 Mark Holmquist 2013-05-16 17:04:19 UTC
Reuploading duplicate files seems like a waste of bandwidth and disk space - you should use redirects, maybe, to accomplish that.

Uploading new revisions, AFAIK, is *not* supported. But if someone disagrees with me I'd be OK with that. Mostly my feeling is that we're looking to support the new contributor who is uploading a set of images, not someone who's revising images, and who should probably be using [[Special:Upload]] instead.

Marking NEW, but I suspect this will be WONTFIX.
Comment 3 Jon Hunter 2013-05-16 17:13:23 UTC
Thanks for getting back to me so quickly!

The users we support are in schools without local backups. As a way for them to backup their work, we've encouraged them to use the wiki to upload what they have at the end of class. They work mostly with SWF and FLA flash files, not images. I understand that in most cases it may be a waste of disk space and bandwidth, but we've been able to accomodate. Maybe there's a configuration setting that can be added to allow new revisions.
Comment 4 Mark Holmquist 2013-05-16 17:17:51 UTC
*revisions* aren't a waste. But if you're getting the "another file on this wiki" message, it means you're updating an identical file. And having two copies of the exact same file is definitely a waste.

If you find anything in the config, let us know! :)
Comment 5 Jon Hunter 2013-05-16 18:18:40 UTC
I jumped into the javascript for this and got it to upload revisions with the same file name. In the 1_20 branch of the UploadWizardDetails.js I edited the following:

in processDestinationCheck:
763 - if ( result.blacklist.notBlacklisted ) { //result.unique.isUnique &&

then in submit:
1319 - } else if ( warnings['exists'] || warnings['exists-normalized'] ) {
     params.ignorewarnings = true;
     _this.upload.api.postWithEditToken( params, ok, err );
//_this.recoverFromError( _this.titleId, gM( 'mwe-upwiz-api-warning-exists', _this.upload.title.getUrl() ) );


With this the Description tab and the first upload tab will not check for duplicate file names and will upload a new revision of the file.

Thanks for pointing me in the right direction!
Comment 6 Mark Holmquist 2013-05-16 18:49:22 UTC
Hey, if you want to upload a patch that does this in a configurable way, we'd love to have it!
Comment 7 Aaron Schulz 2013-05-16 20:19:04 UTC
(In reply to comment #2)
> Reuploading duplicate files seems like a waste of bandwidth and disk space -
> you should use redirects, maybe, to accomplish that.
> 
> Uploading new revisions, AFAIK, is *not* supported. But if someone disagrees
> with me I'd be OK with that. Mostly my feeling is that we're looking to
> support
> the new contributor who is uploading a set of images, not someone who's
> revising images, and who should probably be using [[Special:Upload]] instead.
> 
> Marking NEW, but I suspect this will be WONTFIX.

So if someone needs to upload a re-muxed video file they should use the interface that just times out?
Comment 8 Andre Klapper 2013-05-17 08:24:01 UTC
(In reply to comment #6)
> Hey, if you want to upload a patch that does this in a configurable way, we'd
> love to have it!

To elaborate on this: You are welcome to use Developer access
  https://www.mediawiki.org/wiki/Developer_access
to submit an improved version of the patch as a Git branch directly into Gerrit:
  https://www.mediawiki.org/wiki/Git/Tutorial
Comment 9 Jon Hunter 2013-05-17 21:07:26 UTC
(In reply to comment #8)
> (In reply to comment #6)
> > Hey, if you want to upload a patch that does this in a configurable way, we'd
> > love to have it!
> 
> To elaborate on this: You are welcome to use Developer access
>   https://www.mediawiki.org/wiki/Developer_access
> to submit an improved version of the patch as a Git branch directly into
> Gerrit:
>   https://www.mediawiki.org/wiki/Git/Tutorial

Andre/Aaron/Mark,
Thanks for the feedback and info. We're doing some spring cleaning on our platforms, so I may not be able to get to this for a while. I'll try to get the patch out when things settle down a bit!

Best,
Jon
Comment 10 Nemo 2013-10-11 07:52:57 UTC
Reupload is an entirely legitimate feature of MediaWiki, adjusting severity: as far as I know, this bug is about reupload not being possible at all within UploadWizard, while the ability to upload duplicates is asked at bug 40921.
Comment 12 Marco 2014-06-29 20:42:26 UTC
(In reply to Nemo from comment #10)
> as far as I know, this bug is about reupload not being possible at all
> within UploadWizard, while the ability to upload duplicates is asked at bug
> 40921.

This bug would then be a dupe of bug 40893 ?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links