Last modified: 2013-11-14 20:13:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50509, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48509 - VisualEditor: [Regression] Link inspector button doesn't work
VisualEditor: [Regression] Link inspector button doesn't work
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2013-05-27
Assigned To: Ed Sanders
:
Depends on:
Blocks: 48426
  Show dependency tree / graph
 
Reported: 2013-05-15 12:55 UTC by Ed Sanders
Modified: 2013-11-14 20:13 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-05-15 12:55:24 UTC 
1. Create a link using the link inspector button
2. Note that autocomplete feature doesn't appear
3. Hit save and note that link is stored as an external link "[Foo Foo]"

Using the keyboard shortcut, however, works fine (Ctrl+K)
Comment 1 Ed Sanders 2013-05-15 13:46:52 UTC 
Looks like the format for providing toolbar options was changed, so the MW override isn't working. As a result we're rendering a link button instead of an mwLink. Ctrl+K works because the mwLink is still registered with the command registry (should commands work without the button being rendered?)
Comment 2 Gerrit Notification Bot 2013-05-15 13:56:22 UTC 
Related URL: https://gerrit.wikimedia.org/r/63850 (Gerrit Change Icda3305e422bedaf0d490b8fbe51f55b8c8e79e8)
Comment 3 James Forrester 2013-05-15 17:25:02 UTC 
Merged into master; will go out with wmf5.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links