Last modified: 2013-06-27 21:51:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50385, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48385 - VisualEditor: Delete contents of slugged paragraph results in double line break visible
VisualEditor: Delete contents of slugged paragraph results in double line bre...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Highest normal
: VE-deploy-2013-06-13
Assigned To: Inez Korczyński
:
Depends on:
Blocks: 48426
  Show dependency tree / graph
 
Reported: 2013-05-12 18:50 UTC by Ed Sanders
Modified: 2013-06-27 21:51 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ed Sanders 2013-05-12 18:50:24 UTC 
* Create a page starting with a list ('* list' is sufficient)
* Enter some text into the slugged paragraph above the list, then delete it with backspaces
* The paragraph now doubles in height, inspecting the DOM you see a <br> has appeared from nowhere:
  <p><br><span slug></span></p>

Also this paragraph gets sent to Parsoid resulting in an extra line break.

Removing the text by using undo doesn't result in this bug.
Comment 1 Inez Korczyński 2013-06-12 21:34:16 UTC 
We are not placing slugs around lists anymore so this bug can't be reproduced, however I know what was root cause of it (native handling of deletion) and I'm working on it now.
Comment 2 James Forrester 2013-06-18 02:03:15 UTC 
(In reply to comment #1)
> We are not placing slugs around lists anymore so this bug can't be
> reproduced, however I know what was root cause of it (native handling of 
> deletion) and I'm working on it now.

Is this bug still valid? I can't reproduce now, using a thumb image (rather than a list) to create the block item.
Comment 3 James Forrester 2013-06-21 02:23:03 UTC 
Deeming that this is now fixed.
Comment 4 Inez Korczyński 2013-06-27 21:51:46 UTC 
This is fixed with my refactor to handleDelete method.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links