Last modified: 2013-05-15 17:23:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50347, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 48347 - VisualEditor: "This is a minor edit" is not auto checked in save dialog if the "minordefault" preference is on
VisualEditor: "This is a minor edit" is not auto checked in save dialog if th...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2013-05-27
Assigned To: Ed Sanders
:
Depends on:
Blocks: 48426
  Show dependency tree / graph
 
Reported: 2013-05-11 05:36 UTC by Amir E. Aharoni
Modified: 2013-05-15 17:23 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Amir E. Aharoni 2013-05-11 05:36:40 UTC 
How to reproduce:

1. Enable the "Mark all edits minor by default" option in the preferences.
2. Edit a page in the VisualEditor.
3. Press "Review and save", then "Looks good to me".
4. The edit summary entering bubble appears.

Observed:

* The "This is a minor edit" box is not checked.

Expected:

* The "This is a minor edit" box is checked.

Comment: The saved revision IS correctly marked as minor. It's just the check box that appears incorrectly.

GWT scenario for Cucumber:
Given that I am editing an article while the minordefault preference is on
When I am saving the article
Then the "This is a minor edit" box is checked
Comment 1 Bawolff (Brian Wolff) 2013-05-11 05:40:52 UTC 
You know, if minoredit preference was killed, this wouldn't be an issue...
Comment 2 Amir E. Aharoni 2013-05-11 05:41:44 UTC 
(In reply to comment #1)
> You know, if minoredit preference was killed, this wouldn't be an issue...

I couldn't agree more :)
Comment 3 Gerrit Notification Bot 2013-05-15 12:34:44 UTC 
Related URL: https://gerrit.wikimedia.org/r/63844 (Gerrit Change Ib5cdcb9433be5ff7b9179d3833f42e5c3453285a)
Comment 4 James Forrester 2013-05-15 17:23:18 UTC 
Merged into master; will go out with wmf5.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links