Last modified: 2013-11-14 19:23:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50346, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48346 - VisualEditor: Editing a block level slug causes pawns to be inserted, content corruption
VisualEditor: Editing a block level slug causes pawns to be inserted, content...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Immediate critical
: VE-deploy-2013-05-13
Assigned To: Christian Williams
:
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2013-05-11 05:32 UTC by Ryan Kaldari
Modified: 2013-11-14 19:23 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2013-05-11 05:32:58 UTC
Lately, I've been noticing random pawn characters at the end of paragraphs all over English Wikipedia. The source of these pawns was a mystery to me until I tried using the Visual Editor today. As soon as I started typing in the editor, it inserted a pawn at the end of the line I was editing.

The pawn in question is the white pawn, typically the first piece to move in a game of chess. This makes me wonder if perhaps the visual editor has become sentient and is trying to initiate a friendly game with the editor. Unfortunately, playing chess on Wikipedia was banned in 2006 as a violation of WP:NOT,[1] so it's probably a good idea if we eliminate this sort of behavior.

Actual character: ♙
Unicode value: 2659
UTF-8 value: E2 99 99
Browser: Firefox

1. https://en.wikipedia.org/wiki/Wikipedia:Miscellany_for_deletion/Wikipedia:Chess_championship
Comment 1 Ryan Kaldari 2013-05-11 05:48:23 UTC
Steps to reproduce:
1. Log in and turn on the visual editor.
2. Go to a random article like "Sundance Meadows Airport"
3. Click the Edit tab
4. After the cursor appears on the page, type a character

You will then see a white pawn at the end of the line of text you are editing.

Interestingly, it only seems to happen on articles that insert the cursor into a blank line at the top of the article. I'm not sure what determines that behavior, but it seems to be the behavior for the vast majority of en.wiki articles. The only article I haven't been able to reproduce the bug at so far is Lalage:
https://en.wikipedia.org/wiki/Lalage
Comment 2 Ryan Kaldari 2013-05-11 05:51:58 UTC
I also can't reproduce the bug in my user sandbox:
https://en.wikipedia.org/wiki/User:Kaldari/sandbox
Comment 3 Ryan Kaldari 2013-05-11 06:13:06 UTC
Confirmed in Safari and Chrome as well.
Comment 4 Ryan Kaldari 2013-05-11 06:51:39 UTC
Pawn insertion from May 3:
https://en.wikipedia.org/w/index.php?title=Rubik%27s_360&diff=553360286&oldid=540708795
Comment 5 Fran Rogers 2013-05-11 20:18:43 UTC
Pawn ahoy: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/VisualEditor.git;a=blob;f=modules/ve/ce/ve.ce.Surface.js;h=7ad07c54370cb585ca264f78872fee0c83bd77a5;hb=HEAD#l1009

"git blame" says this section was worked on by Christian Williams, so maybe he'll know what's going on?
Comment 6 Ed Sanders 2013-05-12 17:27:49 UTC
Can't reproduce this is master. It may have already been fixed, pending release?
Comment 7 James Forrester 2013-05-12 20:21:28 UTC
(In reply to comment #1)
> Steps to reproduce:
> 1. Log in and turn on the visual editor.
> 2. Go to a random article like "Sundance Meadows Airport"
> 3. Click the Edit tab
> 4. After the cursor appears on the page, type a character
> 
> You will then see a white pawn at the end of the line of text you are
> editing.

Thanks; have updated the bug report accordingly.

> Interestingly, it only seems to happen on articles that insert the cursor
> into a blank line at the top of the article. I'm not sure what determines
> that behavior, but it seems to be the behavior for the vast majority of
> en.wiki articles.

That is bug 47790. It's not really a blank line in the document; it's the "potential" place to insert some new content, until you click into it and insert some, at which point it's whatever you type in. But it's not really very obvious to users what it is.

> The only article I haven't been able to reproduce the bug at so far
> is Lalage:
> https://en.wikipedia.org/wiki/Lalage

A block-level slug only appears if the page starts with a template or other kind of generated content; any page that starts with one will get one (hence the pervasiveness). The alternative is not giving users the ability to insert content before a template if it happened to be at the start of a document, which would be even more confusing.
Comment 8 James Forrester 2013-05-12 20:23:17 UTC
(In reply to comment #4)
> Pawn insertion from May 3:
> https://en.wikipedia.org/w/index.
> php?title=Rubik%27s_360&diff=553360286&oldid=540708795

These kind of issues are precisely why there's a mandatory pre-save diff for users to read and agree it's fine. If there's a pawn inserted into the article, you're not meant to press save!
Comment 9 James Forrester 2013-05-14 02:21:48 UTC
Confirming that this is fixed in master and wmf4; deployed in the normal deployment train.
Comment 10 Rummana Yasmeen 2013-11-14 19:23:47 UTC
verified for any page https://test2.wikipedia.org/

using chrome Version 26.0.1410.65 and firefox 25.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links