Last modified: 2013-05-16 17:55:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50195, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48195 - VisualEditor: Don't close/re-open annotation when pasting text into a comparable context
VisualEditor: Don't close/re-open annotation when pasting text into a compara...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal critical
: VE-deploy-2013-05-13
Assigned To: Krinkle
:
: 48489 (view as bug list)
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2013-05-07 02:42 UTC by Krinkle
Modified: 2013-05-16 17:55 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2013-05-07 02:42:10 UTC
Not sure whether this is ContentEditable, DataModel or LinearModel.

When pasting italicised text (from elsewhere on the same page) into an already italicised sentence we currently close, re-open, close, re-open that annotation.

Steps to reproduce problem:
* start with:
  <p><i>Original text here.</i></p><p><i>Something else there.</i></p>
* select "else"
* copy
* select "text"
* paste to replace
* end state:
  <p class="ve-ce-branchNode"><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation">Original </i><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation">else</i><i class="ve-ce-TextStyleAnnotation ve-ce-TextStyleItalicAnnotation"> here.</i></p>

Now this wouldn't be a major issue (merely inefficient) if it weren't for bug 48194 in Parsoid.

Real example:
* Intended edit: https://www.mediawiki.org/w/index.php?title=Watchlist_wishlist&diff=686477&oldid=686247
* Actual edit as seen in the Review and save dialog of VisualEditor (and saved as-is): https://www.mediawiki.org/w/index.php?title=Watchlist_wishlist&diff=686475&oldid=686247
Comment 1 James Forrester 2013-05-10 23:32:47 UTC
Timo, can you confirm this in master? I think it's been fixed by Ed's change to how annotations are compared…
Comment 2 Krinkle 2013-05-14 18:00:38 UTC
Confirmed on mediawiki.org
Comment 3 James Forrester 2013-05-16 17:55:43 UTC
*** Bug 48489 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links