Last modified: 2013-07-04 10:33:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50179, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 48179 - Parsoid: HTML comment with immediately following table has newline split removed


Summary:	Parsoid: HTML comment with immediately following table has newline split removed

Status:	RESOLVED FIXED

Product:	Parsoid
Classification:	Unclassified
Component:	General (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized trivial
Target Milestone:	---
Assigned To:	Gabriel Wicke

URL:	http://parsoid.wmflabs.org/_rt/en/BMW...
Whiteboard:
Keywords:

Depends on:
Blocks:	39564
	Show dependency tree / graph

Reported:	2013-05-06 20:38 UTC by James Forrester
Modified:	2013-07-04 10:33 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-05-06 20:38:45 UTC

As per Subbu's report. (The corrupted table is going to be a different bug.)

Comment 1 Gabriel Wicke 2013-05-06 20:46:18 UTC

I get a JS error when trying to preview the diff in that page using FF:
[13:44:04.016] Error: toDomElements() failed to return an array when converting element of type alienBlock @ http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=false&lang=en&modules=ext.visualEditor.core%2Cicons-raster%7Cext.visualEditor.viewPageTarget.icons-raster%7Crangy%7Cunicodejs.wordbreak&skin=vector&version=20130506T190432Z&*:130

Comment 2 James Forrester 2013-05-06 21:07:26 UTC

(In reply to comment #1)
> I get a JS error when trying to preview the diff in that page using FF:
> [13:44:04.016] Error: toDomElements() failed to return an array when
> converting
> element of type alienBlock @
> http://bits.wikimedia.org/en.wikipedia.org/load.
> php?debug=false&lang=en&modules=ext.visualEditor.core%2Cicons-raster%7Cext.
> visualEditor.viewPageTarget.icons-raster%7Crangy%7Cunicodejs.
> wordbreak&skin=vector&version=20130506T190432Z&*:130

Bug 48181.

Comment 3 Gabriel Wicke 2013-05-06 21:37:45 UTC

Can you link to the original report?

Comment 4 James Forrester 2013-05-06 21:43:13 UTC

(In reply to comment #3)
> Can you link to the original report?

The midden of bug 47712.

Comment 5 Gabriel Wicke 2013-05-06 21:45:30 UTC

Those were FF-specific, which points to client-side issues. Are they now an issue independent of the browser?

Comment 6 James Forrester 2013-05-06 21:48:28 UTC

(In reply to comment #5)
> Those were FF-specific, which points to client-side issues. Are they now an
> issue independent of the browser?

Actually, that bit wasn't FF-specific, it was happening in Chrome as well (and I can confirm that it still does).

Comment 7 Gabriel Wicke 2013-05-06 21:53:47 UTC

I am still getting a clean diff with Chromium (and &debug=true to work around current VE breakage). Can you point out any pages that have a dirty diff both in FF and Chrome?

Comment 8 Gerrit Notification Bot 2013-05-07 00:01:57 UTC

Related URL: https://gerrit.wikimedia.org/r/62546 (Gerrit Change If16dda01058715acee8df347b2b9c4da84609113)

Comment 9 Gabriel Wicke 2013-05-07 16:27:30 UTC

Fixed in production.

Comment 10 Andre Klapper 2013-07-04 10:33:21 UTC

[Parsoid component reorg by merging JS/General and General. See bug 50685 for more information. Filter bugmail on this comment. parsoidreorg20130704]

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links