Last modified: 2013-05-22 18:38:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T50159, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 48159 - VisualEditor: Pre-annotations not working in spans
VisualEditor: Pre-annotations not working in spans
Status: RESOLVED DUPLICATE of bug 48720
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: High minor
: ---
Assigned To: Inez Korczyński
:
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2013-05-06 15:01 UTC by ssastry
Modified: 2013-05-22 18:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description ssastry 2013-05-06 15:01:51 UTC
From this bug report on parsoid.wmflabs.org: /mnt/bugs/2013-05-04T01:11:28.439Z-Style_guide%252FAssets_and_gallery

"I typed some text in this paragraph that is styled as a span italic, and VE decided to close and reopen the span on either side of the link. I think that happened before I made the text a link. (This is User:S Page (WMF) here.)"

Relevant diff line below:

− 	
:<span style="font-style: italic;">See Also: [[Commons:Category:MediaWiki style guide]]</span>

+ 	
:<span style="font-style: italic;">See also: </span>[[Wikimedia Foundation Design/Agora Icon Set]] and<span style="font-style: italic;"> [[Commons:Category:MediaWiki style guide]]</span>
Comment 1 James Forrester 2013-05-06 21:41:14 UTC
I think that this partially interacts was a bug that Ed found independently - bug 48110 (now fixed in master). I do not get the span adjusted, but instead get:

:<span style="font-style: italic;">See Also: <a href="Wikimedia_Foundation_Design%2FAgora_Icon_Set" rel="mw:WikiLink">Wikimedia Foundation Design/Agora Icon Set</a> and [[Commons:Category:MediaWiki style guide|<nowiki/>]]<a href="Commons%3ACategory%3AMediaWiki" rel="mw:WikiLink">Commons:Category:MediaWiki</a> style guide</span>

... which is a total mess.
Comment 2 James Forrester 2013-05-16 15:59:20 UTC
OK, we've fixed the secondary issues I was having; have narrowed down the original bug to pre-annotations not being applied to the insertion of text into this context - changing this to suit.
Comment 3 Ed Sanders 2013-05-22 11:22:56 UTC
Can you explain more clearly how this is still broken? What do you mean by pre-annotation?
Comment 4 James Forrester 2013-05-22 18:38:41 UTC
(In reply to comment #3)
> Can you explain more clearly how this is still broken? What do you mean by
> pre-annotation?

On re-testing, this comes down to copy-and-paste inserted content not continuing the existing annotations of the styles into which it had been inserted. Marking as such.

*** This bug has been marked as a duplicate of bug 48720 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links