Last modified: 2013-09-28 00:16:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49946, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47946 - On-wiki configurable user blacklist for Echo
On-wiki configurable user blacklist for Echo
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Echo (Other open bugs)
unspecified
All All
: High enhancement with 1 vote (vote)
: ---
Assigned To: Erik Bernhardson
:
: 50148 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-01 17:44 UTC by Ryan Kaldari
Modified: 2013-09-28 00:16 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ryan Kaldari 2013-05-01 17:44:31 UTC
Certain accounts should to be excluded from generating notifications, such as Signbot, Hostbot, etc. There are a few different ways we could solve this, but one would be an on-wiki configurable blacklist.
Comment 1 Derk-Jan Hartman 2013-05-01 18:59:17 UTC
Related bug: 47910
Comment 2 Oliver Keyes 2013-05-06 14:35:20 UTC
Any way we could fit pages in as well? We've got some concerns around things like SPI.
Comment 3 Technical 13 2013-05-06 15:10:37 UTC
(In reply to comment #3)
> Certain accounts should to be excluded from generating notifications, such as
> Signbot, Hostbot, etc. There are a few different ways we could solve this,
> but one would be an on-wiki configurable blacklist.

This should be a per-user configurable list.  Some people might want to receive notifications when a certain bot uses their name.  For example, I would like to know what pages HostBot uses my name on.
I also think it would be useful for people to know when sinebot signs for them (unless they've opted out), but the people on who's page sinebot is signing should not be notified of a new message on their talk page every time sinebot signs for someone.
I can understand the concern with pages as well for things like SPI and ANI, but am curious how someone knowing they are being investigated could affect the investigation.  I mean, either it will be a hint that they need to shape up and apologize and if they really do mean well, they will do that.  If it is an SPI investigation for someone that only means to do harm, then seeing they are being investigated won't make them do less harm (although it might make them change IPs causing them to be harder to track).
Comment 4 Oliver Keyes 2013-05-06 16:22:21 UTC
(In reply to comment #3)
> (In reply to comment #3)
> > Certain accounts should to be excluded from generating notifications, such as
> > Signbot, Hostbot, etc. There are a few different ways we could solve this,
> > but one would be an on-wiki configurable blacklist.
> 
> This should be a per-user configurable list.  Some people might want to
> receive
> notifications when a certain bot uses their name.  For example, I would like
> to
> know what pages HostBot uses my name on.

Per-user configurable lists dramatically increases the complexity of the use cases that have to be supported. Additionally, implementing it in this fashion makes things very awkward for new users - who presumably start off /without/ a per-user blacklist.

> I also think it would be useful for people to know when sinebot signs for
> them
Can you explain the use case for this?

> (unless they've opted out), but the people on who's page sinebot is signing
> should not be notified of a new message on their talk page every time sinebot
> signs for someone.
> I can understand the concern with pages as well for things like SPI and ANI,
> but am curious how someone knowing they are being investigated could affect
> the
> investigation.  I mean, either it will be a hint that they need to shape up
> and
> apologize and if they really do mean well, they will do that.  If it is an
> SPI
> investigation for someone that only means to do harm, then seeing they are
> being investigated won't make them do less harm (although it might make them
> change IPs causing them to be harder to track).
A lot of people who are prominent long-term abusers are, frankly, attention-seeking. Giving them attention is by definition negative for the project.
Comment 5 Technical 13 2013-05-06 16:36:39 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #3)
> > > Certain accounts should to be excluded from generating notifications,
> > > such as Signbot, Hostbot, etc. There are a few different ways we could
> > > solve this, but one would be an on-wiki configurable blacklist.
> > 
> > This should be a per-user configurable list.  Some people might want to
> > receive notifications when a certain bot uses their name.  For example,
> > I would like to know what pages HostBot uses my name on.
> 
> Per-user configurable lists dramatically increases the complexity of the use
> cases that have to be supported.

I understand this, however, wouldn't it be possible to have the blanket black-list for the site, and then allow people to white-list the ones the want over-riding the blacklist for them?

> Additionally, implementing it in this fashion makes things very awkward for
> new users - who presumably start off /without/ a per-user blacklist.

See response above... Would start with a blanket black-list which removes this concern.

> > I also think it would be useful for people to know when sinebot signs for
> > them (unless they've opted out), but the people on who's page sinebot is
> > signing  should not be notified of a new message on their talk page every
> > time sinebot signs for someone.
> Can you explain the use case for this?

It would serve as a reminder for new users to sign their posts if they got a message every time they forgot, making them more likely to remember to sign it in the future.  For that matter, if it is not worth it to allow this here, perhaps sinebot itself could be modified to post a reminder on the talk page of the user that forgot everytime it has to sign for them.  Of course, if the opt out of automatic signatures with the template, they wouldn't get the reminder.
 
> > I can understand the concern with pages as well for things like SPI and ANI,
> > but am curious how someone knowing they are being investigated could affect
> > the investigation.  I mean, either it will be a hint that they need to
> > shape up and apologize and if they really do mean well, they will do that.
> > If it is an SPI investigation for someone that only means to do harm, then
> > seeing they are being investigated won't make them do less harm
> > (although it might make them change IPs causing them to be harder to track).
> A lot of people who are prominent long-term abusers are, frankly,
> attention-seeking. Giving them attention is by definition negative for the
> project.

Yes, I entirely agree with this; however, I feel that by not allowing those mentioned on those page to see the mentions would be a complete assumption of bad faith and against the one of the very moral fibers of what Wikipedia is.
Comment 6 Ryan Kaldari 2013-05-06 17:28:01 UTC
Having a blacklist per wiki is much simpler to implement than a blacklist per user. So we may implement the former first. I'm interested in hearing ideas for how a per-user blacklist interface would work.
Comment 7 Technical 13 2013-05-06 17:51:15 UTC
(In reply to comment #6)
> Having a blacklist per wiki is much simpler to implement than a blacklist per
> user. So we may implement the former first. I'm interested in hearing ideas
> for how a per-user blacklist interface would work.
Simply, the system would not show notifications from events from any "User" (because bots are users) that are listed on a page named [[MediaWiki:Echo-blacklist]] UNLESS the "User" is listed on [[Special:MyPage/Echo-whitelist]].
Comment 8 Oliver Keyes 2013-05-06 18:03:59 UTC
So it's not a blacklist, it's a whitelist?
Comment 9 Technical 13 2013-05-06 19:05:05 UTC
(In reply to comment #8)
> So it's not a blacklist, it's a whitelist?

LOL to be honest, I don't care how it is done... I would think that the system checking [[Special:MyPage/Echo-blacklist]] would be easier and be done with it.  That would however need to be implemented by every users, so [[MediaWiki/Echo-blacklist]] probably would be better with the option to override it with [[Special:MyPage/Echo-whitelist]].  So, yes, it is either a per-user blacklist, or a site wide blacklist AND a user whitelist that I'm saying.
Comment 10 Oliver Keyes 2013-05-06 19:08:50 UTC
User-by-user modifications are actually incredibly finnicky. I'll be honest; an active blacklist is probably going to be a high priority, but I can't promise when a whitelist to override it could come in (or even if it will).
Comment 11 Technical 13 2013-05-06 19:15:51 UTC
(In reply to comment #10)
> User-by-user modifications are actually incredibly finnicky. I'll be honest;
> an active blacklist is probably going to be a high priority, but I can't promise
> when a whitelist to override it could come in (or even if it will).

I realize that and I would be willing to write the code myself to incorporate the whitelist if I can.  Just point me to the section where the blacklist is incorporated, and I'll amend it to include the whitelist.  The easiest way to make sure that people put it in the right place, is to offer a link to their whitelist on the [[Special:Preferences#mw-prefsection-echo]] page similar to all of the skin/common css/js pages linked to from [[Special:Preferences#mw-prefsection-rendering]].
Comment 12 Ryan Kaldari 2013-05-06 19:56:38 UTC
I'm envisioning several small iterations for this:
1. Hard-code a blacklist per wiki in InitializeSettings.php (in cluster configs) + add support for blocking notifications by those blacklisted users
2. Add support for ingesting an on-wiki blacklist (probably at MediaWiki:Echo-blacklist) so that the communities can manage the blacklists themselves
3. Add support for ingesting per-user whitelists and overriding the blacklist

Or if someone wants to bite off a bigger chunck they could do 1+2, 3 or 1, 2+3.
Comment 13 Gerrit Notification Bot 2013-05-07 16:06:44 UTC
Related URL: https://gerrit.wikimedia.org/r/62624 (Gerrit Change I0d7e071067c6974fb90cf6c0ba1bd159f46bd5df)
Comment 14 Erik Bernhardson 2013-05-21 14:51:24 UTC
Change has been merged, echo documentation on mediawiki.org has also been updated.
Comment 15 Technical 13 2013-05-21 15:05:03 UTC
(In reply to comment #14)
> Change has been merged, echo documentation on mediawiki.org has also been
> updated.

Where?
I don't see it updated on http://www.mediawiki.org/wiki/Echo_(Notifications)
Nor do I see the documentation at http://etherpad.wikimedia.org/echo-release updated either. I don't see it on http://www.mediawiki.org/wiki/Echo_(Notifications)/History and no mention on http://www.mediawiki.org/wiki/Help:Extension:Echo either.  I'm not doubting that documentation was added, I'm just unable to figure out where and would appreciate a link so I can become more informed.  Thanks.
Comment 16 Erik Bernhardson 2013-05-21 15:08:51 UTC
I didn't realize all those other places exist, sorry new here :)

I put the documentation at http://www.mediawiki.org/w/index.php?title=Extension:Echo, should the others all be updated as well?
Comment 17 Erik Bernhardson 2013-05-21 15:09:22 UTC
Additionally the docs could certainly be clearer, if you could suggest what doesn't read very well or isn't clear i will update as necessary.
Comment 18 Oliver Keyes 2013-05-21 15:10:41 UTC
I'll handle the enwiki documentation when the code is deployed; I'd avoid touching 'history', but the help:extension page would probably be good to improve.
Comment 19 Technical 13 2013-05-21 15:29:14 UTC
(In reply to comment #17)
> Additionally the docs could certainly be clearer, if you could suggest what
> doesn't read very well or isn't clear i will update as necessary.

I see no references on any of those pages when I search for "blacklist" which is the topic of this bug report.  The only one of them that mentions it is http://etherpad.wikimedia.org/echo-release under a bullet labeled "* Recommended features:"

Ahh... I found your link there in your reply... I'm sure "most" users will not know what "An sprintf format of per-user notification agent whitelists." means.  "The whitelists must contain one username per line which will always trigger notifications regardless of their existence in the blacklists." is kind of ambiguous and I'm guessing will lead to confusion and trouble.  One username per line as in:
----
Bob
Fred
Sam
----

or

----
User:Bob
User:Fred
User:Sam
----

or

----
[[User:Bob]]
[[User:Fred]]
[[User:Sam]]
----

???

"Set to null to disable."  meaning leave the page blank or actually typing "null" on the page?  Will deleting the page also disable it?

Just some questions I can think of that should be addressed now. ;)
Comment 20 Oliver Keyes 2013-05-21 15:32:10 UTC
(In reply to comment #19)

> I see no references on any of those pages when I search for "blacklist" which
> is the topic of this bug report.  The only one of them that mentions it is
> http://etherpad.wikimedia.org/echo-release under a bullet labeled "*
> Recommended features:"
Sure; as said, I'm going to build the on-wiki documentation over the next couple of days. Note that this code is not deployed, and so having documentation for it is not urgent.
> 
> Ahh... I found your link there in your reply... I'm sure "most" users will
> not
> know what "An sprintf format of per-user notification agent whitelists."
> means.

That's irrelevant. This is documentation for the extension page; it is aimed at developers building for Echo or sysadmins interested in using it on their MediaWiki instances.

> "Set to null to disable."  meaning leave the page blank or actually typing
> "null" on the page?  Will deleting the page also disable it?

Again, this will be documented on enwiki and on the help page, but it's not something users need to be concerned about.
Comment 21 Technical 13 2013-05-21 16:24:15 UTC
I apologize, I wasn't trying to rush it.  I would like to get more involved in development, and figured what a better place to start than to update all of the relevant documentation?  If that would be okay, I just need the information I requested and I would be happy to update all of those document pages I can (not sure if I could update http://etherpad.wikimedia.org/echo-release if I wanted to).  Thanks Oliver.
Comment 22 Oliver Keyes 2013-05-21 16:28:18 UTC
The etherpad is actually largely used for internal tracking. If development's what you're interested in moving into, I recommend https://www.mediawiki.org/wiki/Developer_hub rather than an active extension, I'm afraid :/.
Comment 23 Fabrice Florin 2013-05-21 16:49:31 UTC
Hi guys, 

To help us refine specifications for user and page blacklists for Notifications, I have started this feature requirement stub: 

http://www.mediawiki.org/wiki/Echo_(Notifications)/Feature_requirements#Blacklist

I look forward to updating this first feature requirement with more details, once we've had a chance to discuss them with our development team and key stakeholders.
Comment 24 Ryan Kaldari 2013-05-21 19:01:02 UTC
@ShoeMaker: I elaborated the documentation at https://www.mediawiki.org/wiki/Extension:Echo#Notification_blacklist.2Fwhitelist a bit. Cheers!
Comment 25 Alex Monk 2013-06-26 22:53:11 UTC
*** Bug 50148 has been marked as a duplicate of this bug. ***
Comment 26 MZMcBride 2013-09-27 20:27:47 UTC
[[Special:MyPage/Echo-whitelist]] feels really ugly to me. :-/  I'm having difficulty expressing why exactly, but it makes me feel very weird inside.
Comment 27 Technical 13 2013-09-28 00:16:47 UTC
(In reply to comment #26)
> [[Special:MyPage/Echo-whitelist]] feels really ugly to me. :-/  I'm having
> difficulty expressing why exactly, but it makes me feel very weird inside.

What are you suggesting?
I know there is a discussion on enwp at the moment that would quickly be resolved with a [[Special:MyPage/Echo-blacklist]] option, but I'm trying to avoid that by convincing the community to just add the bot to [[MediaWiki:Echo-blacklist]] as I think that is the best option.
I mean, this bot is just delivering signpost message and messages to the talk pages of members of specific projects, so there is little reason to get the message on their talk page AND have to get a notification.  Those that want the extra notification can always add the bot to their individual whitelist as it is currently set up.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links