Last modified: 2014-02-26 20:41:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49804, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47804 - VisualEditor: "Thumb" images should display in wiki default thumb size
VisualEditor: "Thumb" images should display in wiki default thumb size
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2014-02-27
Assigned To: Moriel Schottlender
https://de.wikipedia.org/wiki/Benutze...
:
: 52487 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-04-28 21:48 UTC by Raimond Spekking
Modified: 2014-02-26 20:41 UTC (History)
10 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of page in view mode (163.23 KB, image/png)
2013-04-28 21:48 UTC, Raimond Spekking
Details
Screenshot in edit mode with smaller thumbnail (69.56 KB, image/png)
2013-04-28 21:49 UTC, Raimond Spekking
Details

Description Raimond Spekking 2013-04-28 21:48:48 UTC
Created attachment 12196 [details]
Screenshot of page in view mode

Show thumbnail in user preference size in edit mode.

1. Set user preference to 300 pixel: "Thumbnail size:" of https://de.wikipedia.org/wiki/Spezial:Einstellungen?uselang=en#mw-prefsection-rendering

2. Edit page with image included as standard thumb.

Thumbnail is shown in a smaller size instead of the user preference size.
Comment 1 Raimond Spekking 2013-04-28 21:49:15 UTC
Created attachment 12197 [details]
Screenshot in edit mode with smaller thumbnail
Comment 2 Inez Korczyński 2013-05-10 20:12:59 UTC
Confirmed with Gabriel (Parsoid team) that this [should|is going to be] solved in VE.
Comment 3 James Forrester 2013-10-01 22:28:00 UTC
*** Bug 52487 has been marked as a duplicate of this bug. ***
Comment 4 Chris McKenna 2013-10-01 22:47:22 UTC
User preference and wiki-default sizes specify the maximum width of an image, regardless of dimensions or aspect ratio, but VE scales the images to fit in a 190px by 212px box.

This means that some images, particularly tall thin ones such as full-length portraits, get rendered at very different sizes in VE edit mode to view mode, with consequential impact on the layout of surrounding content.
Comment 5 Elitre 2014-01-06 14:19:40 UTC
French Wikipedians would like VE to follow the local convention that thumbnails are only displayed with the "upright" option (https://en.wikipedia.org/wiki/Wikipedia:Extended_image_syntax#Size).
Comment 6 Gerrit Notification Bot 2014-02-20 05:18:40 UTC
Change 114420 had a related patch set uploaded by Mooeypoo:
[wip] Set up wiki-default image size

https://gerrit.wikimedia.org/r/114420
Comment 7 Gerrit Notification Bot 2014-02-26 20:31:51 UTC
Change 114420 merged by jenkins-bot:
Set up wiki-default image size

https://gerrit.wikimedia.org/r/114420
Comment 8 James Forrester 2014-02-26 20:41:20 UTC
We have now implemented displaying default images in local wiki default size, and explicitly *not* user-preference size.

This is because the editing surface should encourage users to make the right kind of edits for all users, not just themselves. If a page has an image at default and a second at 300px, and a user with a default of 400px resizes one of the images to fit in with the other, a user with a default of 200px (e.g. an anonymous user) will get a different experience and may try to revert (or the change will have a different effect to what was intended).

I'm therefore re-titling this bug to just refer to local wiki size, and marking as FIXED. Happy to discuss further.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links