Last modified: 2013-08-22 04:35:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 47757 - Move Thanks-specific code to Thanks extension
Move Thanks-specific code to Thanks extension
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Thanks (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: code_quality
  Show dependency treegraph
 
Reported: 2013-04-26 23:21 UTC by Matthew Flaschen
Modified: 2013-08-22 04:35 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2013-04-26 23:21:44 UTC
There's some code that is only used for Thanks in the Echo extension.  I am aware of:
 
1. mw-echo-icon-gratitude (GettingStarted resolves this by having its own Echo stylesheet for this).
2. Option set for echo-subscriptions-email-edit-thank in Echo Hooks.php

Fixing this will provide a better example of how to extend Echo, and help maintainability and separation of concerns.
Comment 1 Ryan Kaldari 2013-04-26 23:24:38 UTC
The gratitude icon isn't Thanks specific (it was actually originally intended for the WikiLove notification which hasn't been built). The part in Hooks.php should be removed though.
Comment 2 Gerrit Notification Bot 2013-04-26 23:29:16 UTC
Related URL: https://gerrit.wikimedia.org/r/61151 (Gerrit Change Ia8be4967d962176f1e58ee6488f4cc9bfe75b655)
Comment 3 Gerrit Notification Bot 2013-04-26 23:37:02 UTC
Related URL: https://gerrit.wikimedia.org/r/61152 (Gerrit Change I1aa81cf81ca71af323f0d5448fb5800086a09b1e)
Comment 4 Gerrit Notification Bot 2013-04-26 23:42:55 UTC
Related URL: https://gerrit.wikimedia.org/r/61156 (Gerrit Change I2a574ebe530a2bb37b85155220f14f999a639587)
Comment 5 Matthew Flaschen 2013-08-22 04:35:21 UTC
The only remaining reference seems to be the Gratitude icon, so this is fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links