Last modified: 2013-07-16 22:06:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T49730, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 47730 - VisualEditor: Message <visualeditor-feedback-link> should be used in content language
VisualEditor: Message <visualeditor-feedback-link> should be used in content ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal minor
: VE-deploy-2013-07-18
Assigned To: Krinkle
:
: 48645 (view as bug list)
Depends on:
Blocks: 48426
  Show dependency treegraph
 
Reported: 2013-04-26 13:00 UTC by Liangent
Modified: 2013-07-16 22:06 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2013-04-26 13:00:32 UTC
Having users using different languages to post feedback on different pages on the same site makes it difficult to manage.
Comment 1 James Forrester 2013-05-17 16:59:01 UTC
(Is this a bug in the core MW feedback tool?)
Comment 2 Liangent 2013-05-17 17:56:08 UTC
I'm not sure what "core MW feedback tool" means, but I was talking about the feedback feature for [[Wikipedia:VisualEditor/Feedback]].
Comment 3 James Forrester 2013-05-17 17:57:51 UTC
(In reply to comment #2)
> I'm not sure what "core MW feedback tool" means, but I was talking about the
> feedback feature for [[Wikipedia:VisualEditor/Feedback]].

Yes, this is a core MediaWiki feature, it just happens to be used by VisualEditor:

  resources/mediawiki/mediawiki.feedback.js
Comment 4 Liangent 2013-05-17 18:03:02 UTC
But there is:

modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js:
		'title': new mw.Title( ve.msg( 'visualeditor-feedback-link' ) ),

shouldn't something like:

new mw.Title( ve.msg( 'visualeditor-feedback-link' ).inContentLanguage() )

be used?
Comment 5 James Forrester 2013-05-17 18:06:36 UTC
Yes, that would fix this particular problem; my question is more as to whether the core tool should default for target link to be in the content language.
Comment 6 Liangent 2013-05-17 18:14:56 UTC
(In reply to comment #5)
> Yes, that would fix this particular problem; my question is more as to
> whether
> the core tool should default for target link to be in the content language.

Based on what I see in the usage given above, you're giving a Title to core feedback tool, which points to a certain page, instead of a message name to core with feedback page name in that message.
Comment 7 Gerrit Notification Bot 2013-05-18 17:37:41 UTC
Related URL: https://gerrit.wikimedia.org/r/64498 (Gerrit Change I3804e6f91015ef9b8ae5196efb37475d714cd7d5)
Comment 8 James Forrester 2013-05-20 16:44:09 UTC
*** Bug 48645 has been marked as a duplicate of this bug. ***
Comment 9 James Forrester 2013-05-20 22:25:20 UTC
Merged and will go out in wmf5.
Comment 10 Nemo 2013-06-30 14:49:16 UTC
pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]: https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/Commenti&oldid=36959657
Comment 11 James Forrester 2013-07-15 01:40:30 UTC
(In reply to comment #10)
> pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with
> Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]:
> https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> Commenti&oldid=36959657

Confirmed, this is also happening to me. Did the code get broken somehow?
Comment 12 Krinkle 2013-07-16 21:27:08 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > pl.wiki is on 1.22wmf8 but my feedback was posted to a non-existing page with
> > Italian title (I have Italian UI), [[pl:Wikipedia:VisualEditor/Commenti]]:
> > https://pl.wikipedia.org/w/index.php?title=Wikipedia:VisualEditor/
> > Commenti&oldid=36959657
> 
> Confirmed, this is also happening to me. Did the code get broken somehow?

Somewhere between https://gerrit.wikimedia.org/r/#/c/68216/ and its parent (I can't seem to find the commit that added it) the message was added in VisualEditor.php's resource module definition. Which caused the message from VisualEditorMessagesModule (in content-language) to be overridden at run time by the one from ResourceLoader for user language.
Comment 13 Gerrit Notification Bot 2013-07-16 21:28:43 UTC
Change 74064 had a related patch set uploaded by Krinkle:
Remove 'visualeditor-feedback-link' from RL module

https://gerrit.wikimedia.org/r/74064
Comment 14 James Forrester 2013-07-16 22:06:25 UTC
Fixed. Sorry about this. Will be deployed this afternoon.
Comment 15 Gerrit Notification Bot 2013-07-16 22:06:52 UTC
Change 74064 merged by jenkins-bot:
Remove 'visualeditor-feedback-link' from RL module

https://gerrit.wikimedia.org/r/74064

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links